You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "airborne12 (via GitHub)" <gi...@apache.org> on 2026/02/10 17:29:28 UTC

[PR] [refactor](search) Refactor SearchDslParser to single-phase ANTLR parsing and fix ES compatibility issues [doris]

airborne12 opened a new pull request, #60654:
URL: https://github.com/apache/doris/pull/60654

   ### What problem does this PR solve?
   
   Problem Summary:
   
   The `search()` function's DSL parser had multiple ES compatibility issues and used a two-phase parsing approach (manual pre-parse + ANTLR) that was error-prone. This PR refactors the parser and fixes several bugs:
   
   1. **SearchDslParser refactoring**: Consolidated from two-phase (manual pre-parse + ANTLR) to single-phase ANTLR parsing. The ANTLR grammar now handles all DSL syntax directly, eliminating the fragile manual pre-parse layer. This fixes issues with operator precedence, grouping, and edge cases.
   
   2. **ANTLR grammar improvements**: Updated `SearchLexer.g4` and `SearchParser.g4` to properly handle quoted phrases, field-qualified expressions, prefix/wildcard/regexp patterns, range queries, and boolean operators with correct precedence.
   
   3. **minimum_should_match pipeline**: Added `default_operator` and `minimum_should_match` fields to `TSearchParam` thrift, passing them from FE `SearchPredicate` through to BE `function_search`. When `minimum_should_match > 0`, uses `OccurBooleanQuery` for proper Lucene-style boolean query semantics.
   
   4. **Wildcard/Prefix/Regexp case-sensitivity**: Wildcard and PREFIX patterns are now lowercased when the index has `parser + lower_case=true` (matching ES query_string normalizer behavior). REGEXP patterns are NOT lowercased (matching ES regex behavior where patterns bypass analysis).
   
   5. **MATCH_ALL_DOCS support**: Added `MATCH_ALL_DOCS` clause type for standalone `*` queries and pure NOT query rewrites. Enhanced `AllQuery` with deferred `max_doc` from `context.segment_num_rows` and nullable field support via `NullableScorer`.
   
   6. **BE fixes**:
      - `regexp_weight._max_expansions`: Changed from 50 to 0 (unlimited) to prevent PREFIX queries from missing documents
      - `occur_boolean_weight`: Fixed swap→append bug when all SHOULD clauses must match, preserving existing MUST scorers
      - Variant subcolumn `index_properties` propagation for proper analyzer selection
      - `lower_case` default handling: inverted index `lower_case` defaults to `"true"` when a parser is configured
   
   ### Release note
   
   Refactor search() DSL parser to single-phase ANTLR parsing and fix multiple ES compatibility issues including minimum_should_match, wildcard case-sensitivity, and MATCH_ALL_DOCS support.
   
   ### Check List (For Author)
   
   - Test
       - [x] Regression test
       - [x] Unit Test
       - [ ] Manual test (add detailed scripts or steps below)
       - [ ] No need to test or manual test. Explain why:
           - [ ] This is a refactor/code format and no logic has been changed.
           - [ ] Previous test can cover this change.
           - [ ] No code files have been changed.
           - [ ] Other reason
   
   - Behavior changed:
       - [x] Yes. Wildcard/PREFIX patterns are now lowercased when index has lower_case=true (matching ES behavior). REGEXP patterns remain case-sensitive. minimum_should_match is now properly passed from FE to BE.
   
   - Does this need documentation?
       - [ ] No.
       - [x] Yes. The search() function now supports minimum_should_match and default_operator parameters with proper ES-compatible semantics.
   
   ### Check List (For Reviewer who merge this PR)
   
   - [ ] Confirm the release note
   - [ ] Confirm test cases
   - [ ] Confirm document
   - [ ] Add branch pick label


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refactor](search) Refactor SearchDslParser to single-phase ANTLR parsing and fix ES compatibility issues [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60654:
URL: https://github.com/apache/doris/pull/60654#issuecomment-3883665301

   # Cloud UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/c12ad996239fda6b58c2bd6d1c0651a8d318f1d4_c12ad996239fda6b58c2bd6d1c0651a8d318f1d4_cloud/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/c12ad996239fda6b58c2bd6d1c0651a8d318f1d4_c12ad996239fda6b58c2bd6d1c0651a8d318f1d4_cloud/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 79.32% (1795/2263) |
   | Line Coverage     | 64.83% (31959/49300) |
   | Region Coverage   | 65.53% (15944/24330) |
   | Branch Coverage   | 56.00% (8470/15124) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refactor](search) Refactor SearchDslParser to single-phase ANTLR parsing and fix ES compatibility issues [doris]

Posted by "airborne12 (via GitHub)" <gi...@apache.org>.
airborne12 commented on PR #60654:
URL: https://github.com/apache/doris/pull/60654#issuecomment-3883538330

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refactor](search) Refactor SearchDslParser to single-phase ANTLR parsing and fix ES compatibility issues [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60654:
URL: https://github.com/apache/doris/pull/60654#issuecomment-3884586794

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 190286 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit c3df6ed55ea90b130589000cc06629529db8c5dd, data reload: false
   
   query5	4311	595	494	494
   query6	323	215	196	196
   query7	4201	461	282	282
   query8	378	256	278	256
   query9	8676	2785	2738	2738
   query10	471	393	334	334
   query11	16575	16401	16167	16167
   query12	169	121	115	115
   query13	1263	439	357	357
   query14	5559	3180	2935	2935
   query14_1	2776	2769	2766	2766
   query15	207	187	172	172
   query16	973	462	450	450
   query17	1102	686	586	586
   query18	2435	447	353	353
   query19	211	213	188	188
   query20	133	125	125	125
   query21	223	147	125	125
   query22	4907	5069	4704	4704
   query23	19137	18699	18277	18277
   query23_1	18518	18479	18441	18441
   query24	6982	1611	1233	1233
   query24_1	1203	1221	1222	1221
   query25	558	473	421	421
   query26	1245	271	158	158
   query27	2755	455	299	299
   query28	4436	1884	1903	1884
   query29	812	560	469	469
   query30	324	250	225	225
   query31	880	763	673	673
   query32	86	77	76	76
   query33	531	341	290	290
   query34	900	905	566	566
   query35	656	691	601	601
   query36	1099	1121	974	974
   query37	144	102	86	86
   query38	2930	2877	2890	2877
   query39	934	908	903	903
   query39_1	867	873	868	868
   query40	220	133	116	116
   query41	66	62	62	62
   query42	111	100	98	98
   query43	424	455	401	401
   query44	1362	740	735	735
   query45	194	186	179	179
   query46	871	986	601	601
   query47	2154	2162	2116	2116
   query48	306	320	235	235
   query49	613	439	351	351
   query50	684	276	215	215
   query51	4100	4101	4113	4101
   query52	99	105	91	91
   query53	298	327	276	276
   query54	293	268	259	259
   query55	86	84	78	78
   query56	312	316	338	316
   query57	1415	1369	1255	1255
   query58	276	268	267	267
   query59	2072	2139	1926	1926
   query60	339	338	314	314
   query61	153	145	143	143
   query62	613	588	513	513
   query63	300	274	263	263
   query64	4807	1236	917	917
   query65	4555	4423	4447	4423
   query66	1439	437	342	342
   query67	16307	16293	16217	16217
   query68	2374	1075	716	716
   query69	392	322	281	281
   query70	1013	972	979	972
   query71	339	322	300	300
   query72	2938	2989	2259	2259
   query73	519	554	316	316
   query74	9615	9691	9592	9592
   query75	2777	2747	2429	2429
   query76	2097	1051	656	656
   query77	349	368	290	290
   query78	11319	11442	10899	10899
   query79	1056	942	601	601
   query80	641	579	519	519
   query81	485	282	258	258
   query82	1254	150	115	115
   query83	360	254	231	231
   query84	255	121	94	94
   query85	836	480	424	424
   query86	362	309	299	299
   query87	3138	3091	3008	3008
   query88	3606	2695	2692	2692
   query89	408	346	316	316
   query90	1930	181	160	160
   query91	193	160	132	132
   query92	82	74	68	68
   query93	920	843	487	487
   query94	457	320	285	285
   query95	587	390	304	304
   query96	669	507	232	232
   query97	2492	2512	2419	2419
   query98	224	211	212	211
   query99	971	948	845	845
   Total cold run time: 260354 ms
   Total hot run time: 190286 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refactor](search) Refactor SearchDslParser to single-phase ANTLR parsing and fix ES compatibility issues [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60654:
URL: https://github.com/apache/doris/pull/60654#issuecomment-3912414995

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 183674 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 17bd6d76e52675a7888c4d31d5fd1e44b9682f31, data reload: false
   
   query5	4682	647	511	511
   query6	336	212	196	196
   query7	4213	476	264	264
   query8	335	235	241	235
   query9	8724	2731	2745	2731
   query10	480	371	342	342
   query11	16983	17600	17040	17040
   query12	187	139	128	128
   query13	1576	492	368	368
   query14	6602	3276	3034	3034
   query14_1	2871	2857	2937	2857
   query15	259	216	186	186
   query16	1080	472	533	472
   query17	1289	755	652	652
   query18	4107	458	354	354
   query19	207	218	183	183
   query20	140	141	137	137
   query21	223	148	129	129
   query22	5287	4991	4956	4956
   query23	17322	16908	16644	16644
   query23_1	16737	16807	16796	16796
   query24	7203	1675	1254	1254
   query24_1	1209	1245	1248	1245
   query25	569	491	421	421
   query26	1236	261	156	156
   query27	2766	499	292	292
   query28	4472	1900	1885	1885
   query29	826	579	492	492
   query30	315	250	214	214
   query31	886	734	670	670
   query32	88	75	76	75
   query33	522	341	287	287
   query34	912	920	559	559
   query35	624	694	602	602
   query36	1082	1167	968	968
   query37	130	96	88	88
   query38	2907	2968	2915	2915
   query39	893	875	870	870
   query39_1	839	838	820	820
   query40	242	151	139	139
   query41	70	67	61	61
   query42	107	103	103	103
   query43	387	384	350	350
   query44	
   query45	202	194	187	187
   query46	892	989	613	613
   query47	2146	2161	2021	2021
   query48	322	324	236	236
   query49	646	508	384	384
   query50	684	290	213	213
   query51	4069	4131	4025	4025
   query52	107	106	93	93
   query53	283	331	280	280
   query54	306	273	256	256
   query55	86	83	77	77
   query56	338	306	303	303
   query57	1395	1350	1262	1262
   query58	283	277	274	274
   query59	2565	2714	2521	2521
   query60	339	346	332	332
   query61	146	143	145	143
   query62	629	596	543	543
   query63	313	282	277	277
   query64	4817	1261	970	970
   query65	
   query66	1422	446	346	346
   query67	16643	16191	16245	16191
   query68	
   query69	395	304	299	299
   query70	998	938	992	938
   query71	339	305	300	300
   query72	2773	2903	2401	2401
   query73	536	558	326	326
   query74	9941	9934	9772	9772
   query75	2840	2760	2448	2448
   query76	2313	1032	689	689
   query77	357	384	305	305
   query78	11253	11369	10698	10698
   query79	3103	828	603	603
   query80	1755	606	516	516
   query81	598	283	256	256
   query82	989	154	112	112
   query83	352	266	245	245
   query84	256	123	100	100
   query85	910	470	427	427
   query86	532	329	300	300
   query87	3131	3086	2980	2980
   query88	3603	2687	2672	2672
   query89	446	367	349	349
   query90	2174	174	173	173
   query91	165	159	132	132
   query92	86	78	70	70
   query93	2233	831	495	495
   query94	651	315	280	280
   query95	580	414	329	329
   query96	648	519	234	234
   query97	2462	2522	2412	2412
   query98	230	217	214	214
   query99	993	1002	900	900
   Total cold run time: 259500 ms
   Total hot run time: 183674 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refactor](search) Refactor SearchDslParser to single-phase ANTLR parsing and fix ES compatibility issues [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60654:
URL: https://github.com/apache/doris/pull/60654#issuecomment-3883823694

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 28.03 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit c12ad996239fda6b58c2bd6d1c0651a8d318f1d4, data reload: false
   
   query1	0.06	0.04	0.04
   query2	0.10	0.04	0.05
   query3	0.25	0.09	0.08
   query4	1.62	0.11	0.11
   query5	0.27	0.24	0.25
   query6	1.18	0.69	0.66
   query7	0.03	0.03	0.02
   query8	0.06	0.04	0.04
   query9	0.57	0.50	0.51
   query10	0.54	0.55	0.55
   query11	0.14	0.09	0.09
   query12	0.14	0.11	0.10
   query13	0.63	0.61	0.61
   query14	1.04	1.05	1.04
   query15	0.87	0.86	0.86
   query16	0.40	0.38	0.39
   query17	1.08	1.12	1.14
   query18	0.23	0.21	0.21
   query19	2.05	1.91	2.03
   query20	0.02	0.01	0.02
   query21	15.42	0.23	0.15
   query22	5.17	0.06	0.05
   query23	15.85	0.29	0.11
   query24	1.45	0.47	0.20
   query25	0.10	0.08	0.06
   query26	0.15	0.14	0.13
   query27	0.08	0.08	0.05
   query28	3.82	1.16	0.97
   query29	12.61	3.92	3.16
   query30	0.31	0.13	0.12
   query31	2.81	0.65	0.40
   query32	3.24	0.59	0.50
   query33	3.19	3.21	3.23
   query34	16.05	5.42	4.72
   query35	4.84	4.75	4.76
   query36	0.66	0.49	0.48
   query37	0.12	0.08	0.06
   query38	0.07	0.04	0.04
   query39	0.04	0.02	0.03
   query40	0.20	0.16	0.16
   query41	0.09	0.03	0.03
   query42	0.04	0.03	0.02
   query43	0.05	0.04	0.03
   Total cold run time: 97.64 s
   Total hot run time: 28.03 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refactor](search) Refactor SearchDslParser to single-phase ANTLR parsing and fix ES compatibility issues [doris]

Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #60654:
URL: https://github.com/apache/doris/pull/60654#issuecomment-3879639861

   
   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
   
   Please clearly describe your PR:
   1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
   2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
   3. What features were added. Why was this function added?
   4. Which code was refactored and why was this part of the code refactored?
   5. Which functions were optimized and what is the difference before and after the optimization?
       


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refactor](search) Refactor SearchDslParser to single-phase ANTLR parsing and fix ES compatibility issues [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60654:
URL: https://github.com/apache/doris/pull/60654#issuecomment-3883801044

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 190923 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit c12ad996239fda6b58c2bd6d1c0651a8d318f1d4, data reload: false
   
   query5	4519	610	495	495
   query6	364	230	205	205
   query7	4231	488	282	282
   query8	356	256	243	243
   query9	8764	2738	2758	2738
   query10	533	375	333	333
   query11	16662	16452	16151	16151
   query12	188	120	121	120
   query13	1267	461	362	362
   query14	6573	3167	3023	3023
   query14_1	2803	2781	2808	2781
   query15	205	190	173	173
   query16	1012	481	372	372
   query17	1089	698	582	582
   query18	2694	438	364	364
   query19	220	203	173	173
   query20	130	123	122	122
   query21	218	151	129	129
   query22	5076	5125	4897	4897
   query23	19226	18730	18438	18438
   query23_1	18651	18578	18469	18469
   query24	7104	1608	1210	1210
   query24_1	1204	1202	1218	1202
   query25	520	455	391	391
   query26	1231	288	159	159
   query27	2751	470	296	296
   query28	4465	1886	1869	1869
   query29	744	554	439	439
   query30	314	251	209	209
   query31	843	738	661	661
   query32	83	81	75	75
   query33	524	350	273	273
   query34	943	939	584	584
   query35	653	692	591	591
   query36	1121	1129	979	979
   query37	140	103	85	85
   query38	2907	2891	2833	2833
   query39	936	898	912	898
   query39_1	895	899	856	856
   query40	217	136	116	116
   query41	65	61	62	61
   query42	103	101	101	101
   query43	457	438	426	426
   query44	1408	723	720	720
   query45	195	189	186	186
   query46	917	1036	605	605
   query47	2214	2211	2119	2119
   query48	312	338	239	239
   query49	596	466	347	347
   query50	711	282	217	217
   query51	4102	4087	4163	4087
   query52	104	112	94	94
   query53	289	342	282	282
   query54	291	262	255	255
   query55	87	81	77	77
   query56	303	309	305	305
   query57	1401	1385	1312	1312
   query58	272	256	259	256
   query59	2011	2129	2142	2129
   query60	337	340	312	312
   query61	143	145	138	138
   query62	610	566	511	511
   query63	307	271	277	271
   query64	4663	1228	932	932
   query65	4541	4427	4465	4427
   query66	1386	458	342	342
   query67	16191	16386	16033	16033
   query68	2507	1107	708	708
   query69	415	318	288	288
   query70	1014	963	943	943
   query71	345	318	298	298
   query72	3024	2814	2523	2523
   query73	540	568	316	316
   query74	9663	9726	9531	9531
   query75	2909	2770	2429	2429
   query76	2256	1154	677	677
   query77	354	382	292	292
   query78	11398	11474	10937	10937
   query79	1018	942	585	585
   query80	626	606	507	507
   query81	501	293	252	252
   query82	244	157	118	118
   query83	260	260	236	236
   query84	254	125	93	93
   query85	830	501	416	416
   query86	336	303	318	303
   query87	3046	3167	2980	2980
   query88	3531	2679	2679	2679
   query89	380	353	314	314
   query90	2097	178	170	170
   query91	177	159	138	138
   query92	79	76	72	72
   query93	900	887	483	483
   query94	459	307	283	283
   query95	609	408	326	326
   query96	654	550	226	226
   query97	2465	2519	2440	2440
   query98	232	223	208	208
   query99	930	934	883	883
   Total cold run time: 261799 ms
   Total hot run time: 190923 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refactor](search) Refactor SearchDslParser to single-phase ANTLR parsing and fix ES compatibility issues [doris]

Posted by "airborne12 (via GitHub)" <gi...@apache.org>.
airborne12 merged PR #60654:
URL: https://github.com/apache/doris/pull/60654


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refactor](search) Refactor SearchDslParser to single-phase ANTLR parsing and fix ES compatibility issues [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #60654:
URL: https://github.com/apache/doris/pull/60654#issuecomment-3915195019

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refactor](search) Refactor SearchDslParser to single-phase ANTLR parsing and fix ES compatibility issues [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60654:
URL: https://github.com/apache/doris/pull/60654#issuecomment-3912386772

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 29677 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 17bd6d76e52675a7888c4d31d5fd1e44b9682f31, data reload: false
   
   ------ Round 1 ----------------------------------
   ============================================
   q1	17681	4503	4350	4350
   q2	q3	10741	790	524	524
   q4	4722	381	262	262
   q5	8172	1239	1049	1049
   q6	236	181	149	149
   q7	830	850	696	696
   q8	10715	1545	1420	1420
   q9	6897	4868	4792	4792
   q10	6921	1896	1649	1649
   q11	485	280	249	249
   q12	749	580	471	471
   q13	17796	4221	3446	3446
   q14	237	234	211	211
   q15	938	790	792	790
   q16	762	727	681	681
   q17	741	865	479	479
   q18	6018	5244	5284	5244
   q19	1166	1065	917	917
   q20	611	591	454	454
   q21	4432	2000	1587	1587
   q22	370	319	257	257
   Total cold run time: 101220 ms
   Total hot run time: 29677 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   ============================================
   q1	4711	4556	4702	4556
   q2	q3	1814	2361	1790	1790
   q4	992	1208	805	805
   q5	4058	4435	4336	4336
   q6	188	177	150	150
   q7	1770	1655	1528	1528
   q8	2455	2719	2551	2551
   q9	7604	7414	7319	7319
   q10	2734	2909	2741	2741
   q11	640	443	408	408
   q12	520	593	459	459
   q13	3961	4483	3618	3618
   q14	282	291	284	284
   q15	847	859	823	823
   q16	724	762	713	713
   q17	1470	1589	1354	1354
   q18	7115	6774	6598	6598
   q19	938	924	999	924
   q20	2098	2170	2015	2015
   q21	4054	3655	3549	3549
   q22	486	453	413	413
   Total cold run time: 49461 ms
   Total hot run time: 46934 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refactor](search) Refactor SearchDslParser to single-phase ANTLR parsing and fix ES compatibility issues [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60654:
URL: https://github.com/apache/doris/pull/60654#issuecomment-3884524204

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 30435 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit c3df6ed55ea90b130589000cc06629529db8c5dd, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	16488	4448	4264	4264
   q2	2057	342	229	229
   q3	9687	1268	733	733
   q4	9851	765	309	309
   q5	7422	2134	1935	1935
   q6	196	181	152	152
   q7	884	742	602	602
   q8	9157	1408	1112	1112
   q9	4606	4689	4600	4600
   q10	6798	1939	1538	1538
   q11	444	271	241	241
   q12	336	375	226	226
   q13	17591	4013	3248	3248
   q14	232	227	216	216
   q15	849	807	804	804
   q16	693	678	623	623
   q17	697	877	448	448
   q18	6561	5823	5868	5823
   q19	1135	1165	716	716
   q20	573	539	439	439
   q21	2783	2056	1904	1904
   q22	382	303	273	273
   Total cold run time: 99422 ms
   Total hot run time: 30435 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4611	4616	4639	4616
   q2	254	344	264	264
   q3	2279	3144	2380	2380
   q4	1416	1848	1415	1415
   q5	4811	4451	4891	4451
   q6	264	188	141	141
   q7	1944	1913	1777	1777
   q8	2769	2343	2360	2343
   q9	7469	7410	7555	7410
   q10	2748	3010	2610	2610
   q11	514	447	414	414
   q12	663	731	603	603
   q13	3930	4339	3772	3772
   q14	283	314	277	277
   q15	851	827	827	827
   q16	670	692	634	634
   q17	1094	1307	1331	1307
   q18	7317	7336	7308	7308
   q19	843	830	824	824
   q20	1968	2069	1885	1885
   q21	4597	4262	4124	4124
   q22	489	442	418	418
   Total cold run time: 51784 ms
   Total hot run time: 49800 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refactor](search) Refactor SearchDslParser to single-phase ANTLR parsing and fix ES compatibility issues [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60654:
URL: https://github.com/apache/doris/pull/60654#issuecomment-3912113921

   # Cloud UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/17bd6d76e52675a7888c4d31d5fd1e44b9682f31_17bd6d76e52675a7888c4d31d5fd1e44b9682f31_cloud/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/17bd6d76e52675a7888c4d31d5fd1e44b9682f31_17bd6d76e52675a7888c4d31d5fd1e44b9682f31_cloud/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 79.33% (1796/2264) |
   | Line Coverage     | 64.84% (32025/49393) |
   | Region Coverage   | 65.55% (15984/24383) |
   | Branch Coverage   | 56.03% (8499/15168) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refactor](search) Refactor SearchDslParser to single-phase ANTLR parsing and fix ES compatibility issues [doris]

Posted by "airborne12 (via GitHub)" <gi...@apache.org>.
airborne12 commented on PR #60654:
URL: https://github.com/apache/doris/pull/60654#issuecomment-3879661936

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refactor](search) Refactor SearchDslParser to single-phase ANTLR parsing and fix ES compatibility issues [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60654:
URL: https://github.com/apache/doris/pull/60654#issuecomment-3913153663

   # FE Regression Coverage Report
   Increment line coverage `  62.50% (70/112)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60654_17bd6d76e52675a7888c4d31d5fd1e44b9682f31_merge_fe/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60654_17bd6d76e52675a7888c4d31d5fd1e44b9682f31_merge_fe/report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refactor](search) Refactor SearchDslParser to single-phase ANTLR parsing and fix ES compatibility issues [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60654:
URL: https://github.com/apache/doris/pull/60654#issuecomment-3883842748

   # FE UT Coverage Report
   Increment line coverage `  48.89% (22/45)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60654_c12ad996239fda6b58c2bd6d1c0651a8d318f1d4/fe_increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60654_c12ad996239fda6b58c2bd6d1c0651a8d318f1d4/fe_report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refactor](search) Refactor SearchDslParser to single-phase ANTLR parsing and fix ES compatibility issues [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60654:
URL: https://github.com/apache/doris/pull/60654#issuecomment-3884422746

   # Cloud UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/c3df6ed55ea90b130589000cc06629529db8c5dd_c3df6ed55ea90b130589000cc06629529db8c5dd_cloud/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/c3df6ed55ea90b130589000cc06629529db8c5dd_c3df6ed55ea90b130589000cc06629529db8c5dd_cloud/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 79.32% (1795/2263) |
   | Line Coverage     | 64.83% (31960/49300) |
   | Region Coverage   | 65.52% (15942/24330) |
   | Branch Coverage   | 56.06% (8479/15124) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refactor](search) Refactor SearchDslParser to single-phase ANTLR parsing and fix ES compatibility issues [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60654:
URL: https://github.com/apache/doris/pull/60654#issuecomment-3884627757

   # FE UT Coverage Report
   Increment line coverage `  48.89% (22/45)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60654_c3df6ed55ea90b130589000cc06629529db8c5dd/fe_increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60654_c3df6ed55ea90b130589000cc06629529db8c5dd/fe_report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refactor](search) Refactor SearchDslParser to single-phase ANTLR parsing and fix ES compatibility issues [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60654:
URL: https://github.com/apache/doris/pull/60654#issuecomment-3913103452

   # BE Regression && UT Coverage Report
   Increment line coverage `74.00% (74/100)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60654_17bd6d76e52675a7888c4d31d5fd1e44b9682f31_merge/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60654_17bd6d76e52675a7888c4d31d5fd1e44b9682f31_merge/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 71.78% (26094/36351) |
   | Line Coverage     | 54.46% (273117/501497) |
   | Region Coverage   | 51.90% (227489/438340) |
   | Branch Coverage   | 53.40% (97732/183022) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refactor](search) Refactor SearchDslParser to single-phase ANTLR parsing and fix ES compatibility issues [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60654:
URL: https://github.com/apache/doris/pull/60654#issuecomment-3883744660

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 30581 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit c12ad996239fda6b58c2bd6d1c0651a8d318f1d4, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17617	4453	4333	4333
   q2	2014	360	239	239
   q3	10110	1313	716	716
   q4	10203	769	315	315
   q5	7448	2187	1913	1913
   q6	200	177	144	144
   q7	893	733	603	603
   q8	9287	1337	1225	1225
   q9	4819	4657	4667	4657
   q10	6831	1937	1547	1547
   q11	486	273	232	232
   q12	349	376	222	222
   q13	17815	4062	3197	3197
   q14	247	238	210	210
   q15	878	806	793	793
   q16	670	679	628	628
   q17	713	802	544	544
   q18	6593	5839	6170	5839
   q19	1193	1046	640	640
   q20	590	555	407	407
   q21	2757	1941	1924	1924
   q22	346	301	253	253
   Total cold run time: 102059 ms
   Total hot run time: 30581 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4614	4575	4704	4575
   q2	278	342	260	260
   q3	2315	2892	2549	2549
   q4	1524	1800	1444	1444
   q5	4608	4497	4676	4497
   q6	236	181	138	138
   q7	1968	1911	1731	1731
   q8	2660	2545	2412	2412
   q9	7730	7446	7355	7355
   q10	2748	3058	2605	2605
   q11	533	442	429	429
   q12	705	796	591	591
   q13	3818	4436	3471	3471
   q14	303	324	296	296
   q15	831	795	778	778
   q16	654	683	633	633
   q17	1094	1271	1324	1271
   q18	7647	7557	7435	7435
   q19	816	813	799	799
   q20	1956	2024	1875	1875
   q21	4592	4201	4046	4046
   q22	547	465	434	434
   Total cold run time: 52177 ms
   Total hot run time: 49624 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refactor](search) Refactor SearchDslParser to single-phase ANTLR parsing and fix ES compatibility issues [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60654:
URL: https://github.com/apache/doris/pull/60654#issuecomment-3885417398

   # FE Regression Coverage Report
   Increment line coverage `  71.11% (32/45)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60654_c3df6ed55ea90b130589000cc06629529db8c5dd_merge_fe/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60654_c3df6ed55ea90b130589000cc06629529db8c5dd_merge_fe/report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refactor](search) Refactor SearchDslParser to single-phase ANTLR parsing and fix ES compatibility issues [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60654:
URL: https://github.com/apache/doris/pull/60654#issuecomment-3885485771

   # BE UT Coverage Report
   Increment line coverage `35.00% (35/100)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/c3df6ed55ea90b130589000cc06629529db8c5dd_c3df6ed55ea90b130589000cc06629529db8c5dd/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/c3df6ed55ea90b130589000cc06629529db8c5dd_c3df6ed55ea90b130589000cc06629529db8c5dd/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 52.78% (19479/36908) |
   | Line Coverage     | 36.28% (181634/500620) |
   | Region Coverage   | 32.59% (140616/431407) |
   | Branch Coverage   | 33.66% (61035/181344) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refactor](search) Refactor SearchDslParser to single-phase ANTLR parsing and fix ES compatibility issues [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60654:
URL: https://github.com/apache/doris/pull/60654#issuecomment-3879878295

   # Cloud UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/cdb0bb58936dad94ce23693157a2228de25d0d27_cdb0bb58936dad94ce23693157a2228de25d0d27_cloud/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/cdb0bb58936dad94ce23693157a2228de25d0d27_cdb0bb58936dad94ce23693157a2228de25d0d27_cloud/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 79.35% (1795/2262) |
   | Line Coverage     | 64.86% (31958/49269) |
   | Region Coverage   | 65.56% (15946/24323) |
   | Branch Coverage   | 56.06% (8473/15114) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refactor](search) Refactor SearchDslParser to single-phase ANTLR parsing and fix ES compatibility issues [doris]

Posted by "airborne12 (via GitHub)" <gi...@apache.org>.
airborne12 commented on PR #60654:
URL: https://github.com/apache/doris/pull/60654#issuecomment-3884188812

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refactor](search) Refactor SearchDslParser to single-phase ANTLR parsing and fix ES compatibility issues [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #60654:
URL: https://github.com/apache/doris/pull/60654#issuecomment-3885513663

   # BE Regression && UT Coverage Report
   Increment line coverage `69.00% (69/100)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/60654_c3df6ed55ea90b130589000cc06629529db8c5dd_merge/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/60654_c3df6ed55ea90b130589000cc06629529db8c5dd_merge/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 73.42% (26554/36169) |
   | Line Coverage     | 56.59% (282609/499391) |
   | Region Coverage   | 54.14% (235935/435794) |
   | Branch Coverage   | 55.86% (101690/182048) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refactor](search) Refactor SearchDslParser to single-phase ANTLR parsing and fix ES compatibility issues [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60654:
URL: https://github.com/apache/doris/pull/60654#issuecomment-3884614317

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 27.92 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit c3df6ed55ea90b130589000cc06629529db8c5dd, data reload: false
   
   query1	0.05	0.05	0.05
   query2	0.13	0.07	0.06
   query3	0.32	0.08	0.07
   query4	1.61	0.11	0.10
   query5	0.26	0.24	0.23
   query6	1.14	0.63	0.65
   query7	0.03	0.03	0.02
   query8	0.08	0.06	0.06
   query9	0.60	0.50	0.49
   query10	0.55	0.56	0.54
   query11	0.26	0.14	0.13
   query12	0.26	0.14	0.14
   query13	0.63	0.62	0.62
   query14	0.99	0.98	0.98
   query15	0.90	0.81	0.82
   query16	0.40	0.39	0.42
   query17	1.05	1.03	1.04
   query18	0.25	0.23	0.23
   query19	1.94	1.73	1.86
   query20	0.02	0.01	0.02
   query21	15.39	0.34	0.30
   query22	4.90	0.13	0.12
   query23	15.33	0.46	0.28
   query24	2.40	0.56	0.39
   query25	0.12	0.11	0.10
   query26	0.20	0.18	0.19
   query27	0.12	0.11	0.11
   query28	3.66	1.17	0.98
   query29	12.52	4.04	3.24
   query30	0.58	0.13	0.10
   query31	2.79	0.68	0.44
   query32	3.24	0.62	0.50
   query33	2.99	3.07	3.03
   query34	16.30	5.10	4.39
   query35	4.41	4.44	4.48
   query36	0.62	0.50	0.49
   query37	0.31	0.09	0.08
   query38	0.28	0.06	0.06
   query39	0.07	0.04	0.04
   query40	0.20	0.16	0.16
   query41	0.14	0.07	0.07
   query42	0.09	0.05	0.05
   query43	0.07	0.06	0.05
   Total cold run time: 98.2 s
   Total hot run time: 27.92 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refactor](search) Refactor SearchDslParser to single-phase ANTLR parsing and fix ES compatibility issues [doris]

Posted by "airborne12 (via GitHub)" <gi...@apache.org>.
airborne12 commented on PR #60654:
URL: https://github.com/apache/doris/pull/60654#issuecomment-3911932041

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [refactor](search) Refactor SearchDslParser to single-phase ANTLR parsing and fix ES compatibility issues [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #60654:
URL: https://github.com/apache/doris/pull/60654#issuecomment-3912760728

   # BE UT Coverage Report
   Increment line coverage `35.00% (35/100)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/17bd6d76e52675a7888c4d31d5fd1e44b9682f31_17bd6d76e52675a7888c4d31d5fd1e44b9682f31/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/17bd6d76e52675a7888c4d31d5fd1e44b9682f31_17bd6d76e52675a7888c4d31d5fd1e44b9682f31/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 52.67% (19535/37092) |
   | Line Coverage     | 36.23% (182121/502736) |
   | Region Coverage   | 32.58% (141365/433955) |
   | Branch Coverage   | 33.61% (61269/182318) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org