You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ignite.apache.org by "Nikolay Izhikov (Jira)" <ji...@apache.org> on 2020/08/14 11:38:00 UTC

[jira] [Commented] (IGNITE-12806) Incorret usage of Class.isAssignableFrom in SystemViewLocal and SystemViewMBean classes

    [ https://issues.apache.org/jira/browse/IGNITE-12806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17177716#comment-17177716 ] 

Nikolay Izhikov commented on IGNITE-12806:
------------------------------------------

LGTM

> Incorret usage of Class.isAssignableFrom in SystemViewLocal and SystemViewMBean classes
> ---------------------------------------------------------------------------------------
>
>                 Key: IGNITE-12806
>                 URL: https://issues.apache.org/jira/browse/IGNITE-12806
>             Project: Ignite
>          Issue Type: Bug
>            Reporter: Andrey N. Gura
>            Assignee: Yaroslav Molochkov
>            Priority: Minor
>              Labels: IEP-35
>             Fix For: 2.10
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Classes {{SystemViewLocal}} and {{SystemViewMBean}} uses method {{Class.isAssignableFrom}} in incorrect manner. I given cases relation is inverted and doesn't have any sense. In most cases usages of {{Class.isAssignableFrom}} could be avoided.
> See creation of {{AttributeVisitor}} and {{AttributeWithValueVisitor}} instance in mentioned classes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)