You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fineract.apache.org by "Vectorquantiy (via GitHub)" <gi...@apache.org> on 2026/05/20 14:51:41 UTC
[PR] FINERACT-2611: Allow MakerCheckerRequest does not accept makerDateTim… [fineract]
Vectorquantiy opened a new pull request, #5864:
URL: https://github.com/apache/fineract/pull/5864
…eFrom and makerDateTimeTo properly
## Description
@QueryParam does not automatically convert String query parameters into java.time.ZonedDateTime.
Therefor makerDateTimeFrom and makerDateTimeTo is always resolving to null in MakerCheckerRequest.
[https://issues.apache.org/jira/browse/FINERACT-2611](url)
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests)
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made.
- [ ] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions).
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [ ] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute).
Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2611: Allow MakerCheckerRequest does not accept makerDateTim… [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #5864:
URL: https://github.com/apache/fineract/pull/5864#issuecomment-4535402052
@Vectorquantiy Please fix the failing CI checks and ensure you have properly configured GPG commit signature in place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2611: Allow MakerCheckerRequest does not accept makerDateTim… [fineract]
Posted by "marta-jankovics (via GitHub)" <gi...@apache.org>.
marta-jankovics commented on code in PR #5864:
URL: https://github.com/apache/fineract/pull/5864#discussion_r3276012065
##########
fineract-core/src/main/java/org/apache/fineract/infrastructure/core/service/DateUtils.java:
##########
@@ -464,6 +464,36 @@ public static LocalDateTime convertDateTimeStringToLocalDateTime(String dateTime
}
}
+ public static OffsetDateTime convertDateTimeStringToOffsetDateTime(String dateTimeStr, String dateFormat, String localeStr,
+ LocalTime fallbackTime) {
+ if (dateTimeStr == null || dateTimeStr.isBlank()) {
+ return null;
+ }
+ final Locale locale = localeStr == null ? null : JsonParserHelper.localeFromString(localeStr);
+ DateTimeFormatter formatter = getDateFormatter(dateFormat, locale);
+ TemporalAccessor parsed = formatter.parse(dateTimeStr);
+
+ boolean hasTime = parsed.isSupported(ChronoField.HOUR_OF_DAY) && parsed.isSupported(ChronoField.MINUTE_OF_HOUR);
+ boolean hasOffset = parsed.isSupported(ChronoField.OFFSET_SECONDS);
+
+ try {
+ if (hasTime && hasOffset) {
+ return OffsetDateTime.from(parsed);
+ } else if (hasTime) {
+ LocalDateTime localDateTime = LocalDateTime.from(parsed);
+ return localDateTime.atOffset(OffsetDateTime.now().getOffset());
Review Comment:
Please use ZoneOffset.UTC getAuditZoneId() instead of now() everywhere
##########
fineract-core/src/main/java/org/apache/fineract/infrastructure/core/service/DateUtils.java:
##########
@@ -464,6 +464,36 @@ public static LocalDateTime convertDateTimeStringToLocalDateTime(String dateTime
}
}
+ public static OffsetDateTime convertDateTimeStringToOffsetDateTime(String dateTimeStr, String dateFormat, String localeStr,
+ LocalTime fallbackTime) {
+ if (dateTimeStr == null || dateTimeStr.isBlank()) {
+ return null;
+ }
+ final Locale locale = localeStr == null ? null : JsonParserHelper.localeFromString(localeStr);
Review Comment:
Locale locale should be passed as parameter
##########
fineract-core/src/main/java/org/apache/fineract/infrastructure/core/service/DateUtils.java:
##########
@@ -464,6 +464,36 @@ public static LocalDateTime convertDateTimeStringToLocalDateTime(String dateTime
}
}
+ public static OffsetDateTime convertDateTimeStringToOffsetDateTime(String dateTimeStr, String dateFormat, String localeStr,
+ LocalTime fallbackTime) {
+ if (dateTimeStr == null || dateTimeStr.isBlank()) {
Review Comment:
minor: Strings.isEmpty(stringDateTime) is simpler
##########
fineract-core/src/main/java/org/apache/fineract/infrastructure/core/service/DateUtils.java:
##########
@@ -464,6 +464,36 @@ public static LocalDateTime convertDateTimeStringToLocalDateTime(String dateTime
}
}
+ public static OffsetDateTime convertDateTimeStringToOffsetDateTime(String dateTimeStr, String dateFormat, String localeStr,
Review Comment:
If we follow the naming convention in this utility parseOffsetDateTime would be consequent.
There are other parseOffsetDateTime methods, could you please move this next to them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2611: Allow MakerCheckerRequest does not accept makerDateTim… [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy merged PR #5864:
URL: https://github.com/apache/fineract/pull/5864
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org