You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hop.apache.org by "vdwals (via GitHub)" <gi...@apache.org> on 2023/10/06 08:57:07 UTC
[PR] [Feature] Feature/3287 - Enable Generating Arrays Inside JSON for Grouped Values (hop)
vdwals opened a new pull request, #3289:
URL: https://github.com/apache/hop/pull/3289
**Description:**
This pull request introduces the ability to generate arrays inside a generated JSON, providing enhanced flexibility for handling grouped values. This addresses #3287
**Changes:**
1. **New Flag**: A new flag has been added to the initial settings screen, with a default value of 'false.' This addition ensures backward compatibility, as existing jobs remain unaffected.
2. **Modified JSON Result for Grouped Values**: Previously, when generating a JSON result for grouped values, the output was an array of JSON objects collected per group. With this update, if the flag is activated, the new result will create a single JSON result in the case of grouping. Inside this element, all non-grouping key fields will be collected in an array.
3. **No Additional Dependencies**: These changes do not introduce any additional external dependencies.
4. **Preservation of Current Behavior**: Importantly, these modifications do not alter the current behavior, ensuring compatibility with existing workflows.
These changes enhance the versatility of JSON generation while maintaining compatibility with previous configurations.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`.
- [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable.
To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature] Feature/3287 - Enable Generating Arrays Inside JSON for Grouped Values (hop)
Posted by "mattcasters (via GitHub)" <gi...@apache.org>.
mattcasters commented on PR #3289:
URL: https://github.com/apache/hop/pull/3289#issuecomment-1789119349
It would be great if you could add an integration test for this transform. Perhaps add it to number 68:
https://github.com/apache/hop/tree/master/integration-tests/transforms
This way we can lock in the new functionality. If you suspect an impact on other functionality, more than 1 test would be appreciated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature] Feature/3287 - Enable Generating Arrays Inside JSON for Grouped Values (hop)
Posted by "hansva (via GitHub)" <gi...@apache.org>.
hansva commented on PR #3289:
URL: https://github.com/apache/hop/pull/3289#issuecomment-1809888416
Awesome work! sorry about the delay!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature] Feature/3287 - Enable Generating Arrays Inside JSON for Grouped Values (hop)
Posted by "hansva (via GitHub)" <gi...@apache.org>.
hansva merged PR #3289:
URL: https://github.com/apache/hop/pull/3289
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org