You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/03 22:08:11 UTC

[GitHub] [beam] kennknowles opened a new issue, #19064: Potential issue with QuantileStateCoder

kennknowles opened a new issue, #19064:
URL: https://github.com/apache/beam/issues/19064

   [https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ApproximateQuantiles.java#L687](https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ApproximateQuantiles.java#L687)
   
   The line above encodes the QuantileState buffers.size() as if it's numBuffers. This seems wrong since before buffers are full, buffers.size() is not equal to numBuffers. One thing I suspect will happen is that, if we serialize before buffer is full, it will effectively reduce the number of buffers we maintain after deserialization.
   
   Imported from Jira [BEAM-4667](https://issues.apache.org/jira/browse/BEAM-4667). Original Jira may contain additional context.
   Reported by: zhihengh.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org