You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "dhruba borthakur (Created) (JIRA)" <ji...@apache.org> on 2012/03/08 02:14:57 UTC
[jira] [Created] (HBASE-5538) A metric to measure the size of the
response queue in the hbase rpc server
A metric to measure the size of the response queue in the hbase rpc server
--------------------------------------------------------------------------
Key: HBASE-5538
URL: https://issues.apache.org/jira/browse/HBASE-5538
Project: HBase
Issue Type: Improvement
Components: ipc
Reporter: dhruba borthakur
Assignee: dhruba borthakur
The HbaseServer queues responses to client (if the client is slow). Expose a metric that records the size of the response queue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5538) A metric to measure the size of the
response queue in the hbase rpc server
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5538:
-------------------------
Status: Patch Available (was: Open)
> A metric to measure the size of the response queue in the hbase rpc server
> --------------------------------------------------------------------------
>
> Key: HBASE-5538
> URL: https://issues.apache.org/jira/browse/HBASE-5538
> Project: HBase
> Issue Type: Improvement
> Components: ipc
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D2199.1.patch
>
>
> The HbaseServer queues responses to client (if the client is slow). Expose a metric that records the size of the response queue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5538) A metric to measure the size of the
response queue in the hbase rpc server
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225619#comment-13225619 ]
Hadoop QA commented on HBASE-5538:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12517613/D2199.1.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 javadoc. The javadoc tool appears to have generated -129 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 155 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
org.apache.hadoop.hbase.mapred.TestTableMapReduce
org.apache.hadoop.hbase.mapreduce.TestImportTsv
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1139//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1139//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1139//console
This message is automatically generated.
> A metric to measure the size of the response queue in the hbase rpc server
> --------------------------------------------------------------------------
>
> Key: HBASE-5538
> URL: https://issues.apache.org/jira/browse/HBASE-5538
> Project: HBase
> Issue Type: Improvement
> Components: ipc
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D2199.1.patch
>
>
> The HbaseServer queues responses to client (if the client is slow). Expose a metric that records the size of the response queue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5538) A metric to measure the size of the
response queue in the hbase rpc server
Posted by "dhruba borthakur (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13226549#comment-13226549 ]
dhruba borthakur commented on HBASE-5538:
-----------------------------------------
Hi folks, can somebody pl commit this? This has passed all unit tests (modulo the ones that fails irrespective of this patch).
> A metric to measure the size of the response queue in the hbase rpc server
> --------------------------------------------------------------------------
>
> Key: HBASE-5538
> URL: https://issues.apache.org/jira/browse/HBASE-5538
> Project: HBase
> Issue Type: Improvement
> Components: ipc
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D2199.1.patch
>
>
> The HbaseServer queues responses to client (if the client is slow). Expose a metric that records the size of the response queue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5538) A metric to measure the size of the
response queue in the hbase rpc server
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272573#comment-13272573 ]
Phabricator commented on HBASE-5538:
------------------------------------
dhruba has closed the revision "[jira] [HBASE-5538] A metric to measure the size of the response queue in the hbase rpc server".
REVISION DETAIL
https://reviews.facebook.net/D2199
To: JIRA, stack, dhruba
> A metric to measure the size of the response queue in the hbase rpc server
> --------------------------------------------------------------------------
>
> Key: HBASE-5538
> URL: https://issues.apache.org/jira/browse/HBASE-5538
> Project: HBase
> Issue Type: Improvement
> Components: ipc
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Fix For: 0.96.0
>
> Attachments: D2199.1.patch
>
>
> The HbaseServer queues responses to client (if the client is slow). Expose a metric that records the size of the response queue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5538) A metric to measure the size of the
response queue in the hbase rpc server
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13226771#comment-13226771 ]
Hudson commented on HBASE-5538:
-------------------------------
Integrated in HBase-TRUNK-security #133 (See [https://builds.apache.org/job/HBase-TRUNK-security/133/])
HBASE-5538 A metric to measure the size of the response queue in the hbase rpc server (Revision 1299084)
Result = FAILURE
stack :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcMetrics.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java
> A metric to measure the size of the response queue in the hbase rpc server
> --------------------------------------------------------------------------
>
> Key: HBASE-5538
> URL: https://issues.apache.org/jira/browse/HBASE-5538
> Project: HBase
> Issue Type: Improvement
> Components: ipc
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Fix For: 0.96.0
>
> Attachments: D2199.1.patch
>
>
> The HbaseServer queues responses to client (if the client is slow). Expose a metric that records the size of the response queue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5538) A metric to measure the size of the
response queue in the hbase rpc server
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-5538:
-------------------------------
Attachment: D2199.1.patch
dhruba requested code review of "[jira] [HBASE-5538] A metric to measure the size of the response queue in the hbase rpc server".
Reviewers: JIRA
Calculate the size of the rpc response queue. Expose it via the metrics api.
TEST PLAN
run all unit tests
REVISION DETAIL
https://reviews.facebook.net/D2199
AFFECTED FILES
src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java
src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcMetrics.java
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/4827/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> A metric to measure the size of the response queue in the hbase rpc server
> --------------------------------------------------------------------------
>
> Key: HBASE-5538
> URL: https://issues.apache.org/jira/browse/HBASE-5538
> Project: HBase
> Issue Type: Improvement
> Components: ipc
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D2199.1.patch
>
>
> The HbaseServer queues responses to client (if the client is slow). Expose a metric that records the size of the response queue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5538) A metric to measure the size of the
response queue in the hbase rpc server
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225562#comment-13225562 ]
Phabricator commented on HBASE-5538:
------------------------------------
stack has accepted the revision "[jira] [HBASE-5538] A metric to measure the size of the response queue in the hbase rpc server".
+1
REVISION DETAIL
https://reviews.facebook.net/D2199
BRANCH
svn
> A metric to measure the size of the response queue in the hbase rpc server
> --------------------------------------------------------------------------
>
> Key: HBASE-5538
> URL: https://issues.apache.org/jira/browse/HBASE-5538
> Project: HBase
> Issue Type: Improvement
> Components: ipc
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D2199.1.patch
>
>
> The HbaseServer queues responses to client (if the client is slow). Expose a metric that records the size of the response queue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5538) A metric to measure the size of the
response queue in the hbase rpc server
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13227982#comment-13227982 ]
Hudson commented on HBASE-5538:
-------------------------------
Integrated in HBase-TRUNK #2676 (See [https://builds.apache.org/job/HBase-TRUNK/2676/])
HBASE-5538 A metric to measure the size of the response queue in the hbase rpc server (Revision 1299084)
Result = FAILURE
stack :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcMetrics.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java
> A metric to measure the size of the response queue in the hbase rpc server
> --------------------------------------------------------------------------
>
> Key: HBASE-5538
> URL: https://issues.apache.org/jira/browse/HBASE-5538
> Project: HBase
> Issue Type: Improvement
> Components: ipc
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Fix For: 0.96.0
>
> Attachments: D2199.1.patch
>
>
> The HbaseServer queues responses to client (if the client is slow). Expose a metric that records the size of the response queue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5538) A metric to measure the size of the
response queue in the hbase rpc server
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5538:
-------------------------
Resolution: Fixed
Fix Version/s: 0.96.0
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed to trunk. Thanks for the patch Dhruba.
> A metric to measure the size of the response queue in the hbase rpc server
> --------------------------------------------------------------------------
>
> Key: HBASE-5538
> URL: https://issues.apache.org/jira/browse/HBASE-5538
> Project: HBase
> Issue Type: Improvement
> Components: ipc
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Fix For: 0.96.0
>
> Attachments: D2199.1.patch
>
>
> The HbaseServer queues responses to client (if the client is slow). Expose a metric that records the size of the response queue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira