You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/12/15 02:01:12 UTC

[GitHub] [kafka] ijuma commented on a change in pull request #9748: MINOR: Simplify ApiKeys by relying on ApiMessageType and removing unused methods

ijuma commented on a change in pull request #9748:
URL: https://github.com/apache/kafka/pull/9748#discussion_r542987065



##########
File path: generator/src/main/java/org/apache/kafka/message/ApiMessageTypeGenerator.java
##########
@@ -169,7 +169,7 @@ private void generateEnumValues() {
     }
 
     private void generateInstanceVariables() {
-        buffer.printf("private final String name;%n");
+        buffer.printf("public final String name;%n");

Review comment:
       Yeah, that's an existing problem with ApiKeys too. The enum method cannot be overridden. I think it should be tackled separately.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org