[GitHub] [flink] danny0405 commented on a change in pull request #11116: [FLINK-15349] add 'create catalog' DDL to blink planner

[GitBox <gi...@apache.org>]

danny0405 commented on a change in pull request #11116: [FLINK-15349] add 'create catalog' DDL to blink planner
URL: https://github.com/apache/flink/pull/11116#discussion_r381046554
 
 

 ##########
 File path: flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/SqlCommandParserTest.java
 ##########
 @@ -83,6 +83,7 @@ public void testCommands() {
 		testValidSqlCommand("reset;", new SqlCommandCall(SqlCommand.RESET));
 		testValidSqlCommand("source /my/file", new SqlCommandCall(SqlCommand.SOURCE, new String[] {"/my/file"}));
 		testInvalidSqlCommand("source"); // missing path
+		testValidSqlCommand("create CATALOG c1", new SqlCommandCall(SqlCommand.CREATE_CATALOG, new String[]{"create catalog c1"}));
 		testValidSqlCommand("USE CATALOG default", new SqlCommandCall(SqlCommand.USE_CATALOG, new String[]{"default"}));
 
 Review comment:
   Can also add a test with explicit 'WITH' options.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services