You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/10/07 13:53:18 UTC
[GitHub] [shardingsphere-elasticjob] TeslaCN opened a new pull request #1545: Simplify JobRegistry
TeslaCN opened a new pull request #1545:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1545
Changes proposed in this pull request:
- Simplify JobRegistry.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] codecov-io commented on pull request #1545: Simplify JobRegistry
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1545:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1545#issuecomment-705000552
# [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1545?src=pr&el=h1) Report
> Merging [#1545](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1545?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/9557d605988d29fa82fad37ec921de97f4ef77aa?el=desc) will **decrease** coverage by `0.12%`.
> The diff coverage is `100.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1545/graphs/tree.svg?width=650&height=150&src=pr&token=8ZMVc4Yo4Z)](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1545?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1545 +/- ##
============================================
- Coverage 85.28% 85.16% -0.13%
Complexity 101 101
============================================
Files 247 247
Lines 5676 5670 -6
Branches 890 886 -4
============================================
- Hits 4841 4829 -12
- Misses 525 530 +5
- Partials 310 311 +1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1545?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...elasticjob/lite/internal/schedule/JobRegistry.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1545/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc2NoZWR1bGUvSm9iUmVnaXN0cnkuamF2YQ==) | `96.55% <100.00%> (-0.60%)` | `0.00 <0.00> (ø)` | |
| [...ticjob/lite/internal/snapshot/SnapshotService.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1545/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc25hcHNob3QvU25hcHNob3RTZXJ2aWNlLmphdmE=) | `77.77% <0.00%> (-4.77%)` | `1.00% <0.00%> (ø%)` | |
| [...e/shardingsphere/elasticjob/infra/env/IpUtils.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1545/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLWluZnJhLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9pbmZyYS9lbnYvSXBVdGlscy5qYXZh) | `60.00% <0.00%> (-4.62%)` | `0.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1545?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1545?src=pr&el=footer). Last update [9557d60...a426ef9](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1545?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] terrymanu merged pull request #1545: Simplify JobRegistry
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #1545:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1545
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org