You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/10 06:12:30 UTC

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #38589: [SPARK-41087][BUILD] Make `build/mvn` use the same JAVA_OPTS as `dev/make-distribution.sh`

dongjoon-hyun commented on code in PR #38589:
URL: https://github.com/apache/spark/pull/38589#discussion_r1018688674


##########
build/mvn:
##########
@@ -36,7 +36,7 @@ _DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
 # Preserve the calling directory
 _CALLING_DIR="$(pwd)"
 # Options used during compilation
-_COMPILE_JVM_OPTS="-Xmx2g -XX:ReservedCodeCacheSize=1g -Xss128m"
+_COMPILE_JVM_OPTS="-Xss128m -Xmx4g -Xmx4g -XX:ReservedCodeCacheSize=128m"

Review Comment:
   May I ask why you repeat `-Xmx4g` twice?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org