[GitHub] [hudi] danny0405 commented on a diff in pull request #8542: [HUDI-6123] Auto adjust lock configs only for single writer

["danny0405 (via GitHub)" <gi...@apache.org>]

danny0405 commented on code in PR #8542:
URL: https://github.com/apache/hudi/pull/8542#discussion_r1290819723


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -2483,8 +2483,15 @@ public boolean areReleaseResourceEnabled() {
   /**
    * Returns whether the explicit guard of lock is required.
    */
-  public boolean needsLockGuard() {
-    return isMetadataTableEnabled() || getWriteConcurrencyMode().supportsOptimisticConcurrencyControl();
+  public boolean isLockRequired() {
+    return !isDefaultLockProvider() || getWriteConcurrencyMode().supportsOptimisticConcurrencyControl();

Review Comment:
   Yeah, I was expecting the use to set up the optimistic concurrency control explicitly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org