You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@santuario.apache.org by "jrihtarsic (via GitHub)" <gi...@apache.org> on 2024/05/04 07:31:45 UTC
Re: [PR] [SANTUARIO-614] Tests for the EC Brainpool key types [santuario-xml-security-java]
jrihtarsic commented on code in PR #298:
URL: https://github.com/apache/santuario-xml-security-java/pull/298#discussion_r1589920012
##########
src/test/resources/org/apache/xml/security/samples/input/README.txt:
##########
Review Comment:
I have addressed the ‘title comments’ above.
Regarding the keystore, I fully agree with the reasoning. Going forward, I will try to use keytool with "ProcessBuilder" to generate certificates before running tests in my future contributions. With the latest enhancements in JDK 17, keytool has become the best tool for this task.
However, testing certain features and certificates with non keytool supported key types with older JDKs using various JCPs may pose some challenges. But we will tackle that when there :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@santuario.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org