[kudu-CR] KUDU-3326 [master] add flag FLAGS enable soft delete on master to enable soft-delete on master

["Abhishek Chennaka (Code Review)" <ge...@cloudera.org>]

Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/18864 )

Change subject: KUDU-3326 [master] add flag FLAGS_enable_soft_delete_on_master to enable soft-delete on master
......................................................................


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18864/1/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:

http://gerrit.cloudera.org:8080/#/c/18864/1/src/kudu/master/catalog_manager.cc@409
PS1, Line 409: enable_soft_delete_on_master
> Usually, the client and server need to be updated at the same time for a ne
But shouldn't the ideal behavior be - if the soft deletes are disabled on the master and the client tries to do a soft delete, it should receive an error message saying it is disabled on the server end?



-- 
To view, visit http://gerrit.cloudera.org:8080/18864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf3021fa0e9a425d5f8091ea3336c55a3c14bbc
Gerrit-Change-Number: 18864
Gerrit-PatchSet: 7
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Thu, 01 Sep 2022 04:27:48 +0000
Gerrit-HasComments: Yes