[GitHub] [superset] Alex-Monahan edited a comment on pull request #19317: feat: add duckdb as DataSource - Fixes #14563

[GitBox <gi...@apache.org>]

Alex-Monahan edited a comment on pull request #19317:
URL: https://github.com/apache/superset/pull/19317#issuecomment-1077630595


   Since DuckDB is, much like SQLite, an in-process, single-threaded engine, the error handling in `TestConnectionDatabaseCommand.run` feels a bit weird. Might want to work with @Mause on a narrow exception class for the 
   
   I had one small comment in case it is helpful! DuckDB is indeed embedded in your local process, but it is multi-threaded and can use as many CPU cores as you would like. 
   
   Thanks for building this connector!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org