You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2024/02/06 04:02:00 UTC

[jira] [Commented] (IMPALA-12784) ScanNode. getFilteredInputCardinality is buggy.

    [ https://issues.apache.org/jira/browse/IMPALA-12784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17814591#comment-17814591 ] 

ASF subversion and git services commented on IMPALA-12784:
----------------------------------------------------------

Commit 7b773063d42c17c8fbb1b7f4673df3d5202244c7 in impala's branch refs/heads/master from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=7b773063d ]

IMPALA-12784: Fix bug in ScanNode.getFilteredInputCardinality

IMPALA-12018 adds method ScanNode.getFilteredInputCardinality(), which
is intended to return filteredInputCardinality_ if it set, but
mistakenly return filteredCardinality_ instead.
filteredInputCardinality_ is only affected by partition runtime filter
or runtime filter pushed to Kudu. On the other hand,
filteredCardinality_ is affected by all runtime filter consumed by a
ScanNode. This patch fixes the bug.

This patch also adds TRACE log at the end of
ScanNode.reduceCardinalityByRuntimeFilter()

Testing:
- Pass FE tests.

Change-Id: Iae41f0fe5907cfed6ac67c156e975cf9964a7559
Reviewed-on: http://gerrit.cloudera.org:8080/20993
Reviewed-by: Riza Suminto <ri...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


> ScanNode. getFilteredInputCardinality is buggy.
> -----------------------------------------------
>
>                 Key: IMPALA-12784
>                 URL: https://issues.apache.org/jira/browse/IMPALA-12784
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Frontend
>            Reporter: Riza Suminto
>            Assignee: Riza Suminto
>            Priority: Major
>
> Instead of returning filteredInputCardinality_, the current function return filteredCardinality_, which is wrong.
> https://github.com/apache/impala/blob/3c93437b7a6191a9ca1ef3acc740fefd2ae54bcf/fe/src/main/java/org/apache/impala/planner/ScanNode.java#L340



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org