You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2019/02/13 17:57:16 UTC

[GitHub] jvrao commented on a change in pull request #1946: (WIP) Have min time interval for force compaction.

jvrao commented on a change in pull request #1946: (WIP) Have min time interval for force compaction.
URL: https://github.com/apache/bookkeeper/pull/1946#discussion_r256516196
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java
 ##########
 @@ -245,6 +250,20 @@ public void disableForceGC() {
         }
     }
 
+    public void enableForceGCIfMinIntervalElapsed() {
+        long curTime = System.currentTimeMillis();
+        if ((lastMainCompactionTime.longValue() - curTime) > forceCompactionInterval) {
 
 Review comment:
   yeah curTime will be >= lastMain isn't it @reddycharan ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services