You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/04/23 06:44:51 UTC
[GitHub] [fineract] fynmanoj opened a new pull request #1708: Fineract 1349
fynmanoj opened a new pull request #1708:
URL: https://github.com/apache/fineract/pull/1708
## Description
https://issues.apache.org/jira/browse/FINERACT-1349
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] fynmanoj commented on pull request #1708: Fineract 1349
Posted by GitBox <gi...@apache.org>.
fynmanoj commented on pull request #1708:
URL: https://github.com/apache/fineract/pull/1708#issuecomment-917079069
one of the commit is same as that i n another PR : https://github.com/apache/fineract/pull/1702, once that is merged, i hall rebase and send this as a new single commit PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #1708: Fineract 1349
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #1708:
URL: https://github.com/apache/fineract/pull/1708#issuecomment-950126491
Can you adjust this PR now as the other one has been merged? @fynmanoj , We will be very grateful for the new fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] closed pull request #1708: Fineract 1349
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #1708:
URL: https://github.com/apache/fineract/pull/1708
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #1708: Fineract 1349
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #1708:
URL: https://github.com/apache/fineract/pull/1708#issuecomment-916959962
Trying to Reopen this for review. Seem another PR was opened in its place. This seems to contain commits fixing 2 different issues. ITs say the branch was already recreated or forced pushed.. You have to send another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] commented on pull request #1708: Fineract 1349
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #1708:
URL: https://github.com/apache/fineract/pull/1708#issuecomment-846664349
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org