You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Hector Acosta (Code Review)" <ge...@cloudera.org> on 2019/04/03 01:29:02 UTC
[native-toolchain-CR] Check for thirft.protocol.fastbinary in both lib and lib64
Hector Acosta has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12915
Change subject: Check for thirft.protocol.fastbinary in both lib and lib64
......................................................................
Check for thirft.protocol.fastbinary in both lib and lib64
db301f6b992d36ea315c037fde954e01340be1e2 introduced an assertion on
the thrift build script which ensures that thrift.protocol.fastbinary
gets compiled in thrift's python bindings, however in some distros, the
shared object is placed on $PY_PREFIX/lib64 (instead of $PY_PREFIX/lib)
so we check in both locations.
Change-Id: Ib2294eff2f945af94de0345322f5496777fb1b08
---
M source/thrift/build.sh
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/15/12915/1
--
To view, visit http://gerrit.cloudera.org:8080/12915
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib2294eff2f945af94de0345322f5496777fb1b08
Gerrit-Change-Number: 12915
Gerrit-PatchSet: 1
Gerrit-Owner: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
[native-toolchain-CR] Check for thirft.protocol.fastbinary in both lib and lib64
Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Marshall has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12915 )
Change subject: Check for thirft.protocol.fastbinary in both lib and lib64
......................................................................
Check for thirft.protocol.fastbinary in both lib and lib64
db301f6b992d36ea315c037fde954e01340be1e2 introduced an assertion on
the thrift build script which ensures that thrift.protocol.fastbinary
gets compiled in thrift's python bindings, however in some distros, the
shared object is placed on $PY_PREFIX/lib64 (instead of $PY_PREFIX/lib)
so we check in both locations.
Change-Id: Ib2294eff2f945af94de0345322f5496777fb1b08
Reviewed-on: http://gerrit.cloudera.org:8080/12915
Reviewed-by: Thomas Marshall <tm...@cloudera.com>
Tested-by: Thomas Marshall <tm...@cloudera.com>
---
M source/thrift/build.sh
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Thomas Marshall: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/12915
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib2294eff2f945af94de0345322f5496777fb1b08
Gerrit-Change-Number: 12915
Gerrit-PatchSet: 2
Gerrit-Owner: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>