You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/23 08:17:46 UTC

[GitHub] [flink] JingsongLi opened a new pull request #10661: [FLINK-15193][table][documentation] Move DDL to first tab in table connector page

JingsongLi opened a new pull request #10661: [FLINK-15193][table][documentation] Move DDL to first tab in table connector page
URL: https://github.com/apache/flink/pull/10661
 
 
   
   ## What is the purpose of the change
   
   Since we have a good support for DDL in tableEnv.sqlUpdate and SQL-CLI, I think it is time to highlight DDL in the document.
   
   ## Brief change log
   
   Move DDL to first tab in table connector page
   
   ## Verifying this change
   
   This change is a trivial rework without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive):no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper:no
     - The S3 file system connector:no
   
   ## Documentation
   
     - Does this pull request introduce a new feature?no

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10661: [FLINK-15193][FLINK-15243][table][documentation] Move DDL to first tab in table connector page&Fix line feed in DDL

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10661: [FLINK-15193][FLINK-15243][table][documentation] Move DDL to first tab in table connector page&Fix line feed in DDL
URL: https://github.com/apache/flink/pull/10661#issuecomment-568405694
 
 
   <!--
   Meta data
   Hash:f0ff0225317ab9b56640fda86ff97b0888175d6d Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3855 TriggerType:PUSH TriggerID:f0ff0225317ab9b56640fda86ff97b0888175d6d
   Hash:f0ff0225317ab9b56640fda86ff97b0888175d6d Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/142088912 TriggerType:PUSH TriggerID:f0ff0225317ab9b56640fda86ff97b0888175d6d
   Hash:a405f1045f8e2c9ff8e22b27457dc62840a7e37f Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142091279 TriggerType:PUSH TriggerID:a405f1045f8e2c9ff8e22b27457dc62840a7e37f
   Hash:a405f1045f8e2c9ff8e22b27457dc62840a7e37f Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3857 TriggerType:PUSH TriggerID:a405f1045f8e2c9ff8e22b27457dc62840a7e37f
   Hash:c82e47d74b0ca17f739278575e77832bc32f0589 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:c82e47d74b0ca17f739278575e77832bc32f0589
   -->
   ## CI report:
   
   * f0ff0225317ab9b56640fda86ff97b0888175d6d Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/142088912) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3855) 
   * a405f1045f8e2c9ff8e22b27457dc62840a7e37f Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142091279) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3857) 
   * c82e47d74b0ca17f739278575e77832bc32f0589 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10661: [FLINK-15193][FLINK-15243][table][documentation] Move DDL to first tab in table connector page&Fix line feed in DDL

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10661: [FLINK-15193][FLINK-15243][table][documentation] Move DDL to first tab in table connector page&Fix line feed in DDL
URL: https://github.com/apache/flink/pull/10661#issuecomment-568405694
 
 
   <!--
   Meta data
   Hash:f0ff0225317ab9b56640fda86ff97b0888175d6d Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:f0ff0225317ab9b56640fda86ff97b0888175d6d
   -->
   ## CI report:
   
   * f0ff0225317ab9b56640fda86ff97b0888175d6d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] JingsongLi commented on issue #10661: [FLINK-15193][FLINK-15243][table][documentation] Move DDL to first tab in table connector page&Fix line feed in DDL

Posted by GitBox <gi...@apache.org>.
JingsongLi commented on issue #10661: [FLINK-15193][FLINK-15243][table][documentation] Move DDL to first tab in table connector page&Fix line feed in DDL
URL: https://github.com/apache/flink/pull/10661#issuecomment-568628307
 
 
   Thanks @wuchong for reviewing, updated.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] wuchong closed pull request #10661: [FLINK-15193][FLINK-15243][table][documentation] Move DDL to first tab in table connector page&Fix line feed in DDL

Posted by GitBox <gi...@apache.org>.
wuchong closed pull request #10661: [FLINK-15193][FLINK-15243][table][documentation] Move DDL to first tab in table connector page&Fix line feed in DDL
URL: https://github.com/apache/flink/pull/10661
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10661: [FLINK-15193][FLINK-15243][table][documentation] Move DDL to first tab in table connector page&Fix line feed in DDL

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10661: [FLINK-15193][FLINK-15243][table][documentation] Move DDL to first tab in table connector page&Fix line feed in DDL
URL: https://github.com/apache/flink/pull/10661#issuecomment-568405694
 
 
   <!--
   Meta data
   Hash:f0ff0225317ab9b56640fda86ff97b0888175d6d Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3855 TriggerType:PUSH TriggerID:f0ff0225317ab9b56640fda86ff97b0888175d6d
   Hash:f0ff0225317ab9b56640fda86ff97b0888175d6d Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142088912 TriggerType:PUSH TriggerID:f0ff0225317ab9b56640fda86ff97b0888175d6d
   Hash:a405f1045f8e2c9ff8e22b27457dc62840a7e37f Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:a405f1045f8e2c9ff8e22b27457dc62840a7e37f
   -->
   ## CI report:
   
   * f0ff0225317ab9b56640fda86ff97b0888175d6d Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142088912) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3855) 
   * a405f1045f8e2c9ff8e22b27457dc62840a7e37f UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10661: [FLINK-15193][table][documentation] Move DDL to first tab in table connector page

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10661: [FLINK-15193][table][documentation] Move DDL to first tab in table connector page
URL: https://github.com/apache/flink/pull/10661#issuecomment-568399157
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit f0ff0225317ab9b56640fda86ff97b0888175d6d (Mon Dec 23 08:20:25 UTC 2019)
   
    ✅no warnings
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] wuchong commented on a change in pull request #10661: [FLINK-15193][FLINK-15243][table][documentation] Move DDL to first tab in table connector page&Fix line feed in DDL

Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #10661: [FLINK-15193][FLINK-15243][table][documentation] Move DDL to first tab in table connector page&Fix line feed in DDL
URL: https://github.com/apache/flink/pull/10661#discussion_r360918552
 
 

 ##########
 File path: docs/dev/table/connect.md
 ##########
 @@ -1857,7 +1858,8 @@ CREATE TABLE MyUserTable (
   'format.fields.1.data-type' = 'TIMESTAMP(3)',
 
   'format.field-delimiter' = ',',         -- optional: string delimiter "," by default
-  'format.line-delimiter' = '\n',         -- optional: string delimiter "\n" by default
+  'format.line-delimiter' = U&'\000A',    -- optional: string delimiter "\n" by default
+                                          -- NOTE: should use unicode to describe line feed.
 
 Review comment:
   What about 
   
   ```
   -- optional: string delimiter line feed by default, 
   -- unicode is supported if the delimiter is an invisible special character, 
   -- e.g. U&'\000A' is the unicode representation of line feed "\n"
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10661: [FLINK-15193][FLINK-15243][table][documentation] Move DDL to first tab in table connector page&Fix line feed in DDL

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10661: [FLINK-15193][FLINK-15243][table][documentation] Move DDL to first tab in table connector page&Fix line feed in DDL
URL: https://github.com/apache/flink/pull/10661#issuecomment-568405694
 
 
   <!--
   Meta data
   Hash:f0ff0225317ab9b56640fda86ff97b0888175d6d Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3855 TriggerType:PUSH TriggerID:f0ff0225317ab9b56640fda86ff97b0888175d6d
   Hash:f0ff0225317ab9b56640fda86ff97b0888175d6d Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/142088912 TriggerType:PUSH TriggerID:f0ff0225317ab9b56640fda86ff97b0888175d6d
   Hash:a405f1045f8e2c9ff8e22b27457dc62840a7e37f Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142091279 TriggerType:PUSH TriggerID:a405f1045f8e2c9ff8e22b27457dc62840a7e37f
   Hash:a405f1045f8e2c9ff8e22b27457dc62840a7e37f Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3857 TriggerType:PUSH TriggerID:a405f1045f8e2c9ff8e22b27457dc62840a7e37f
   -->
   ## CI report:
   
   * f0ff0225317ab9b56640fda86ff97b0888175d6d Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/142088912) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3855) 
   * a405f1045f8e2c9ff8e22b27457dc62840a7e37f Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142091279) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3857) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10661: [FLINK-15193][FLINK-15243][table][documentation] Move DDL to first tab in table connector page&Fix line feed in DDL

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10661: [FLINK-15193][FLINK-15243][table][documentation] Move DDL to first tab in table connector page&Fix line feed in DDL
URL: https://github.com/apache/flink/pull/10661#issuecomment-568405694
 
 
   <!--
   Meta data
   Hash:f0ff0225317ab9b56640fda86ff97b0888175d6d Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3855 TriggerType:PUSH TriggerID:f0ff0225317ab9b56640fda86ff97b0888175d6d
   Hash:f0ff0225317ab9b56640fda86ff97b0888175d6d Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/142088912 TriggerType:PUSH TriggerID:f0ff0225317ab9b56640fda86ff97b0888175d6d
   Hash:a405f1045f8e2c9ff8e22b27457dc62840a7e37f Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142091279 TriggerType:PUSH TriggerID:a405f1045f8e2c9ff8e22b27457dc62840a7e37f
   Hash:a405f1045f8e2c9ff8e22b27457dc62840a7e37f Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3857 TriggerType:PUSH TriggerID:a405f1045f8e2c9ff8e22b27457dc62840a7e37f
   -->
   ## CI report:
   
   * f0ff0225317ab9b56640fda86ff97b0888175d6d Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/142088912) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3855) 
   * a405f1045f8e2c9ff8e22b27457dc62840a7e37f Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142091279) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3857) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services