[kudu-CR] tracing: gzip the trace JSON ajax response

["Todd Lipcon (Code Review)" <ge...@cloudera.org>]

Todd Lipcon has posted comments on this change.

Change subject: tracing: gzip the trace JSON ajax response
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/4154/1//COMMIT_MSG
Commit Message:

Line 16: the server side. A corresponding commit on the JS side adds a slight
> question: don't we need both of these commits together to avoid breaking pu
actually already pushed the trace-viewer commit, and this commit updates the hash in thirdparty


http://gerrit.cloudera.org:8080/#/c/4154/1/src/kudu/server/tracing-path-handlers.cc
File src/kudu/server/tracing-path-handlers.cc:

PS1, Line 262: kEndRecordingCompressed
> oh, I see, we support both compressed and decompressed, so it won't break a
yea, and also this patch does the update to the new version (though I left the non-compressed version since it might be useful in some cases)


http://gerrit.cloudera.org:8080/#/c/4154/1/src/kudu/tserver/tablet_server-test.cc
File src/kudu/tserver/tablet_server-test.cc:

Line 166: string ZlibUncompress(const faststring& compressed) {
> yeah, seems like if we have both compress and decompress this could be in u
will do.


-- 
To view, visit http://gerrit.cloudera.org:8080/4154
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8d5966e65b51576bf1460cb1ea8c2240ea88cbc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes