[GitHub] [beam] damccorm commented on pull request #26846: [WIP] Add Spec Files + PreCommit Test

["damccorm (via GitHub)" <gi...@apache.org>]

damccorm commented on PR #26846:
URL: https://github.com/apache/beam/pull/26846#issuecomment-1562908822

   I ran it, but it would be good to get the local setup working. Going back and forth on the seed job is going to be generally slow/non-ideal.
   
   > Also, if you can point me to an existing test that invokes the runner directly via gradle, that will be helpful. I looked in the repo and wasn't able to find any, so am not sure if I am invoking the runner correctly.
   
   I think we pretty much exclusively do our testing through [tox](https://github.com/apache/beam/blob/master/sdks/python/tox.ini) which eventually calls pytest which kicks off tests that invoke the runner. I wouldn't recommend directly invoking the runner in a gradle script, I'd at least wrap it in a script like https://github.com/apache/beam/blob/master/sdks/python/scripts/run_integration_test.sh (though that still wraps it in a pytest call).
   
   I guess we do have https://github.com/apache/beam/blob/43d7ec0a147156f25f9f1d5288c47ca9a56a7adf/sdks/python/build.gradle#L166 which directly invokes a wordcount pipeline; that's not the pattern we generally follow, but it might be ok here


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org