[GitHub] [mesos] lava commented on a change in pull request #327: Updated glog to 0.3.5 and then to 0.4.0, added microseconds to LogSink::send().

[GitBox <gi...@apache.org>]

lava commented on a change in pull request #327: Updated glog to 0.3.5 and then to 0.4.0, added microseconds to LogSink::send().
URL: https://github.com/apache/mesos/pull/327#discussion_r268554431
 
 

 ##########
 File path: 3rdparty/Makefile.am
 ##########
 @@ -248,8 +248,17 @@ $(LIB_GLOG): $(GLOG)-build-stamp
 # when building with clang).
 # We explicitly build only libglog.la as it is the artifact we depend
 # on. This e.g., avoids building glog-internal tests.
+#
+# NOTE:
+# On some platforms patch fails to remove test-driver (it is a broken symlink),
+# that's why we need to remove it here.
+# Also, autogen.sh might be CREATED by the patch and might need its mode fixed.
 $(GLOG)-build-stamp: $(GLOG)-stamp
-	cd $(GLOG) && ./configure GTEST_CONFIG=no $(CONFIGURE_ARGS) && \
+	cd $(GLOG) &&\
+	  rm -f test-driver &&\
+	  chmod a+x ./autogen.sh &&\
+	  ./autogen.sh && \
 
 Review comment:
   Since `autogen.sh` is a one-liner anyways, it seems like we could make things simpler here by just calling `autoreconf -i $(GLOG)` and removing `autogen.sh` from the patch.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services