You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@opennlp.apache.org by wcolen <gi...@git.apache.org> on 2017/03/15 22:22:04 UTC
[GitHub] opennlp pull request #143: OPENNLP-788: [WIP] Add initial langdetect impleme...
GitHub user wcolen opened a pull request:
https://github.com/apache/opennlp/pull/143
OPENNLP-788: [WIP] Add initial langdetect implementation
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
- [X] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wcolen/opennlp OPENNLP-788a
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/opennlp/pull/143.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #143
----
commit 5fdaf653cc2a790c2a5007711b1abacebda9ba56
Author: William D C M SILVA <co...@apache.org>
Date: 2017-03-13T16:48:33Z
OPENNLP-788: Add LanguageDetector infrastructure classes
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] opennlp pull request #143: OPENNLP-788: Add initial
langdetect implementatio...
Posted by William Colen <wi...@gmail.com>.
+1 to think how to do it. Polyglot is doing it already.
2017-05-18 22:28 GMT-03:00 <dr...@apache.org>:
> Can the language detector find when the language changes? I have data in
> French and English, I would love to be able to pull separate the two.
> Daniel
>
>
> > On May 17, 2017, at 12:38 PM, wcolen <gi...@git.apache.org> wrote:
> >
> > Github user wcolen closed the pull request at:
> >
> > https://github.com/apache/opennlp/pull/143
> >
> >
> > ---
> > If your project is set up for it, you can reply to this email and have
> your
> > reply appear on GitHub as well. If your project does not have this
> feature
> > enabled and wishes so, or if the feature is enabled but not working,
> please
> > contact infrastructure at infrastructure@apache.org or file a JIRA
> ticket
> > with INFRA.
> > ---
>
>
Re: [GitHub] opennlp pull request #143: OPENNLP-788: Add initial langdetect implementatio...
Posted by dr...@apache.org.
Can the language detector find when the language changes? I have data in French and English, I would love to be able to pull separate the two.
Daniel
> On May 17, 2017, at 12:38 PM, wcolen <gi...@git.apache.org> wrote:
>
> Github user wcolen closed the pull request at:
>
> https://github.com/apache/opennlp/pull/143
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
[GitHub] opennlp pull request #143: OPENNLP-788: Add initial langdetect implementatio...
Posted by wcolen <gi...@git.apache.org>.
Github user wcolen closed the pull request at:
https://github.com/apache/opennlp/pull/143
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---