You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Colm O hEigeartaigh <co...@apache.org> on 2017/08/09 09:49:28 UTC

Review Request 61519: RANGER-1728 - Upgrade PMD plugin and fix related issues

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61519/
-----------------------------------------------------------

Review request for ranger.


Bugs: RANGER-1728
    https://issues.apache.org/jira/browse/RANGER-1728


Repository: ranger


Description
-------

Upgrade PMD plugin and fix related issues.


Diffs
-----

  agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTUtils.java 961b8bc2 
  plugin-atlas/src/main/java/org/apache/ranger/authorization/atlas/authorizer/RangerAtlasAuthorizer.java acd11115 
  plugin-yarn/src/main/java/org/apache/ranger/authorization/yarn/authorizer/RangerYarnAuthorizer.java b4488304 
  pom.xml 01005b7a 
  security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java a3e9746e 


Diff: https://reviews.apache.org/r/61519/diff/1/


Testing
-------


Thanks,

Colm O hEigeartaigh


Re: Review Request 61519: RANGER-1728 - Upgrade PMD plugin and fix related issues

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61519/#review184168
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On Aug. 30, 2017, 11:03 a.m., Colm O hEigeartaigh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61519/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2017, 11:03 a.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1728
>     https://issues.apache.org/jira/browse/RANGER-1728
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Upgrade PMD plugin and fix related issues.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTUtils.java 961b8bc2 
>   plugin-atlas/src/main/java/org/apache/ranger/authorization/atlas/authorizer/RangerAtlasAuthorizer.java acd11115 
>   plugin-yarn/src/main/java/org/apache/ranger/authorization/yarn/authorizer/RangerYarnAuthorizer.java b4488304 
>   pom.xml 01005b7a 
>   security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java a3e9746e 
> 
> 
> Diff: https://reviews.apache.org/r/61519/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Colm O hEigeartaigh
> 
>


Re: Review Request 61519: RANGER-1728 - Upgrade PMD plugin and fix related issues

Posted by Qiang Zhang <zh...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61519/#review184225
-----------------------------------------------------------


Ship it!




Ship It!

- Qiang Zhang


On 八月 30, 2017, 11:03 a.m., Colm O hEigeartaigh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61519/
> -----------------------------------------------------------
> 
> (Updated 八月 30, 2017, 11:03 a.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1728
>     https://issues.apache.org/jira/browse/RANGER-1728
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Upgrade PMD plugin and fix related issues.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTUtils.java 961b8bc2 
>   plugin-atlas/src/main/java/org/apache/ranger/authorization/atlas/authorizer/RangerAtlasAuthorizer.java acd11115 
>   plugin-yarn/src/main/java/org/apache/ranger/authorization/yarn/authorizer/RangerYarnAuthorizer.java b4488304 
>   pom.xml 01005b7a 
>   security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java a3e9746e 
> 
> 
> Diff: https://reviews.apache.org/r/61519/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Colm O hEigeartaigh
> 
>


Re: Review Request 61519: RANGER-1728 - Upgrade PMD plugin and fix related issues

Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61519/
-----------------------------------------------------------

(Updated Aug. 30, 2017, 11:03 a.m.)


Review request for ranger.


Changes
-------

Whitespace fix


Bugs: RANGER-1728
    https://issues.apache.org/jira/browse/RANGER-1728


Repository: ranger


Description
-------

Upgrade PMD plugin and fix related issues.


Diffs (updated)
-----

  agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTUtils.java 961b8bc2 
  plugin-atlas/src/main/java/org/apache/ranger/authorization/atlas/authorizer/RangerAtlasAuthorizer.java acd11115 
  plugin-yarn/src/main/java/org/apache/ranger/authorization/yarn/authorizer/RangerYarnAuthorizer.java b4488304 
  pom.xml 01005b7a 
  security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java a3e9746e 


Diff: https://reviews.apache.org/r/61519/diff/2/

Changes: https://reviews.apache.org/r/61519/diff/1-2/


Testing
-------


Thanks,

Colm O hEigeartaigh


Re: Review Request 61519: RANGER-1728 - Upgrade PMD plugin and fix related issues

Posted by Qiang Zhang <zh...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61519/#review183338
-----------------------------------------------------------



.git/rebase-apply/patch:81: trailing whitespace.
				matchFound = (xColumnFamilies == null || xColumnFamilies.length == 0) 
warning: 1 line adds whitespace errors.

Please fixed it.

- Qiang Zhang


On 八月 9, 2017, 9:49 a.m., Colm O hEigeartaigh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61519/
> -----------------------------------------------------------
> 
> (Updated 八月 9, 2017, 9:49 a.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1728
>     https://issues.apache.org/jira/browse/RANGER-1728
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Upgrade PMD plugin and fix related issues.
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTUtils.java 961b8bc2 
>   plugin-atlas/src/main/java/org/apache/ranger/authorization/atlas/authorizer/RangerAtlasAuthorizer.java acd11115 
>   plugin-yarn/src/main/java/org/apache/ranger/authorization/yarn/authorizer/RangerYarnAuthorizer.java b4488304 
>   pom.xml 01005b7a 
>   security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java a3e9746e 
> 
> 
> Diff: https://reviews.apache.org/r/61519/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Colm O hEigeartaigh
> 
>