You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by miguelaferreira <gi...@git.apache.org> on 2015/06/02 14:49:03 UTC
[GitHub] cloudstack pull request: Set the url accordingly when installing a...
GitHub user miguelaferreira opened a pull request:
https://github.com/apache/cloudstack/pull/348
Set the url accordingly when installing a system vm template
The script that installs the system vm templates sets the uuid column in table vm_template, however it does not set the respective url column. This PR addresses that.
Before the change, I would install the system vm template for master, using this url: http://jenkins.buildacloud.org/job/build-systemvm64-master/lastSuccessfulBuild/artifact/tools/appliance/dist/systemvm64template-master-4.6.0-xen.vhd.bz2
But a select on the vm_template table would show a different url:
```sql
use cloud
select * from vm_template;
+----+--------------------+---------------------------------------+--------------------------------------+--------+----------+---------+-----+------+------------------------------------------------------------------------------------------------------------+--------+---------------------+---------------------+------------+----------------------------------+---------------------------------------+-----------------+---------------+-------------+----------+-------------+-------------+-------------+-----------------+--------------------+--------------+----------+------+----------+--------------+---------+----------------------+
| id | unique_name | name | uuid | public | featured | type | hvm | bits | url | format | created | removed | account_id | checksum | display_text | enable_password | enable_sshkey | guest_os_id | bootable | prepopulate | cross_zones | extractable | hypervisor_type | source_template_id | template_tag | sort_key | size | state | update_count | updated | dynamically_scalable |
+----+--------------------+---------------------------------------+--------------------------------------+--------+----------+---------+-----+------+------------------------------------------------------------------------------------------------------------+--------+---------------------+---------------------+------------+----------------------------------+---------------------------------------+-----------------+---------------+-------------+----------+-------------+-------------+-------------+-----------------+--------------------+--------------+----------+------+----------+--------------+---------+----------------------+
| 1 | routing-1 | SystemVM Template (XenServer) | 1a6bf182-091c-11e5-b368-5254001daa61 | 0 | 0 | SYSTEM | 0 | 64 | http://download.cloud.com/templates/4.5/systemvm64template-4.5-xen.vhd.bz2 | VHD | 2015-06-02 07:40:01 | NULL | 1 | 2b15ab4401c2d655264732d3fc600241 | SystemVM Template (XenServer) | 0 | 0 | 184 | 1 | 0 | 1 | 0 | XenServer | NULL | NULL | 0 | NULL | Active | 0 | NULL | 0 |
```
After the change, I re-installed the template using the same url, and it got propagated to the table:
```sql
use cloud
select * from vm_template;
+----+--------------------+---------------------------------------+--------------------------------------+--------+----------+---------+-----+------+----------------------------------------------------------------------------------------------------------------------------------------------------------+--------+---------------------+---------------------+------------+----------------------------------+---------------------------------------+-----------------+---------------+-------------+----------+-------------+-------------+-------------+-----------------+--------------------+--------------+----------+------+----------+--------------+---------+----------------------+
| id | unique_name | name | uuid | public | featured | type | hvm | bits | url | format | created | removed | account_id | checksum | display_text | enable_password | enable_sshkey | guest_os_id | bootable | prepopulate | cross_zones | extractable | hypervisor_type | source_template_id | template_tag | sort_key | size | state | update_count | updated | dynamically_scalable |
+----+--------------------+---------------------------------------+--------------------------------------+--------+----------+---------+-----+------+----------------------------------------------------------------------------------------------------------------------------------------------------------+--------+---------------------+---------------------+------------+----------------------------------+---------------------------------------+-----------------+---------------+-------------+----------+-------------+-------------+-------------+-----------------+--------------------+--------------+----------+------+----------+--------------+---------+----------------------+
| 1 | routing-1 | SystemVM Template (XenServer) | b41f2028-a53c-4528-84ca-e0eddec14280 | 0 | 0 | SYSTEM | 0 | 64 | http://jenkins.buildacloud.org/job/build-systemvm64-master/lastSuccessfulBuild/artifact/tools/appliance/dist/systemvm64template-master-4.6.0-xen.vhd.bz2 | VHD | 2015-06-02 07:40:01 | NULL | 1 | 2b15ab4401c2d655264732d3fc600241 | SystemVM Template (XenServer) | 0 | 0 | 184 | 1 | 0 | 1 | 0 | XenServer | NULL | NULL | 0 | NULL | Active | 0 | NULL | 0 |
```
Note that I do not check if the `-u` option was specified as is mandatory for the execution of the script, and the script will abort if it is not present:
```bash
...
while getopts 'm:h:f:u:Ft:e:s:o:r:d:' OPTION
do
case $OPTION in
...
u) uflag=1
url="$OPTARG"
;;
...
esac
done
if [[ "$mflag$fflag" != "11" && "$mflag$uflag" != "11" ]]
then
usage
failed 2
fi
...
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/schubergphilis/cloudstack install-template-set-url
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/348.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #348
----
commit 64d24cf2112dc987fbff00c83c62f8bdd031ecad
Author: miguelaferreira <mi...@me.com>
Date: 2015-06-02T12:23:31Z
Set the url accordingly when installing a system vm template
The script that installs the system vm templates sets the uuid column
for the template being installed, however it does not set the respective
url column. This commit changes that.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Set the url accordingly when installing a...
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/348#issuecomment-107943258
Will have a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Set the url accordingly when installing a...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/348
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Set the url accordingly when installing a...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/348#issuecomment-107947092
looks like a good improvement
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Set the url accordingly when installing a...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/348#issuecomment-107965895
Thanks @miguelaferreira looking good. Just merged it to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---