You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Carlos Santana <cs...@gmail.com> on 2013/09/25 19:12:27 UTC
CB-4900 device-orientation windows8 code review?
Can someone review this proposed fix and if OK merge into dev?
Windows 8 Compass plugin have extra define breaks plugin loading:
https://issues.apache.org/jira/browse/CB-4900
https://github.com/apache/cordova-plugin-device-orientation/pull/3
--
Carlos Santana
<cs...@gmail.com>
Re: CB-4900 device-orientation windows8 code review?
Posted by Jesse <pu...@gmail.com>.
Never mind that last request, way to easy to mix up device-motion and
device-orientation, who named this stuff?
@purplecabbage
risingj.com
On Wed, Sep 25, 2013 at 10:40 AM, Jesse <pu...@gmail.com> wrote:
> It's good, I'd pull it in, but there are merge issues.
> Can you update to include the latest commits to the dev branch?
>
> @purplecabbage
> risingj.com
>
>
> On Wed, Sep 25, 2013 at 10:12 AM, Carlos Santana <cs...@gmail.com>wrote:
>
>> Can someone review this proposed fix and if OK merge into dev?
>>
>> Windows 8 Compass plugin have extra define breaks plugin loading:
>>
>> https://issues.apache.org/jira/browse/CB-4900
>>
>> https://github.com/apache/cordova-plugin-device-orientation/pull/3
>>
>> --
>> Carlos Santana
>> <cs...@gmail.com>
>>
>
>
Re: CB-4900 device-orientation windows8 code review?
Posted by Jesse <pu...@gmail.com>.
ugh, done ...
@purplecabbage
risingj.com
On Wed, Sep 25, 2013 at 11:18 AM, Carlos Santana <cs...@gmail.com>wrote:
> Jesse your commit left from conflict markers in at the top
>
> <<<<<<< HEAD
> /*
> =======
> cordova.define("org.apache.cordova.device-orientation.CompassProxy",
> function(require, exports, module) {/*
> >>>>>>> d863af77758d0d58f4bdb71cc0ba2f30b9d24228
>
>
> Please review mine:
> https://github.com/apache/cordova-plugin-device-orientation/pull/3
>
>
>
> On Wed, Sep 25, 2013 at 1:54 PM, Jesse <pu...@gmail.com> wrote:
>
> >
> >
> https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-device-orientation.git;a=commit;h=9d32a18404d5fefb609f4e844f955be426b6773d
> >
> > @purplecabbage
> > risingj.com
> >
> >
> > On Wed, Sep 25, 2013 at 10:47 AM, Carlos Santana <csantana23@gmail.com
> > >wrote:
> >
> > > will do
> > >
> > >
> > >
> > > On Wed, Sep 25, 2013 at 1:40 PM, Jesse <pu...@gmail.com>
> wrote:
> > >
> > > > It's good, I'd pull it in, but there are merge issues.
> > > > Can you update to include the latest commits to the dev branch?
> > > >
> > > > @purplecabbage
> > > > risingj.com
> > > >
> > > >
> > > > On Wed, Sep 25, 2013 at 10:12 AM, Carlos Santana <
> csantana23@gmail.com
> > > > >wrote:
> > > >
> > > > > Can someone review this proposed fix and if OK merge into dev?
> > > > >
> > > > > Windows 8 Compass plugin have extra define breaks plugin loading:
> > > > >
> > > > > https://issues.apache.org/jira/browse/CB-4900
> > > > >
> > > > > https://github.com/apache/cordova-plugin-device-orientation/pull/3
> > > > >
> > > > > --
> > > > > Carlos Santana
> > > > > <cs...@gmail.com>
> > > > >
> > > >
> > >
> > >
> > >
> > > --
> > > Carlos Santana
> > > <cs...@gmail.com>
> > >
> >
>
>
>
> --
> Carlos Santana
> <cs...@gmail.com>
>
Re: CB-4900 device-orientation windows8 code review?
Posted by Carlos Santana <cs...@gmail.com>.
Jesse your commit left from conflict markers in at the top
<<<<<<< HEAD
/*
=======
cordova.define("org.apache.cordova.device-orientation.CompassProxy",
function(require, exports, module) {/*
>>>>>>> d863af77758d0d58f4bdb71cc0ba2f30b9d24228
Please review mine:
https://github.com/apache/cordova-plugin-device-orientation/pull/3
On Wed, Sep 25, 2013 at 1:54 PM, Jesse <pu...@gmail.com> wrote:
>
> https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-device-orientation.git;a=commit;h=9d32a18404d5fefb609f4e844f955be426b6773d
>
> @purplecabbage
> risingj.com
>
>
> On Wed, Sep 25, 2013 at 10:47 AM, Carlos Santana <csantana23@gmail.com
> >wrote:
>
> > will do
> >
> >
> >
> > On Wed, Sep 25, 2013 at 1:40 PM, Jesse <pu...@gmail.com> wrote:
> >
> > > It's good, I'd pull it in, but there are merge issues.
> > > Can you update to include the latest commits to the dev branch?
> > >
> > > @purplecabbage
> > > risingj.com
> > >
> > >
> > > On Wed, Sep 25, 2013 at 10:12 AM, Carlos Santana <csantana23@gmail.com
> > > >wrote:
> > >
> > > > Can someone review this proposed fix and if OK merge into dev?
> > > >
> > > > Windows 8 Compass plugin have extra define breaks plugin loading:
> > > >
> > > > https://issues.apache.org/jira/browse/CB-4900
> > > >
> > > > https://github.com/apache/cordova-plugin-device-orientation/pull/3
> > > >
> > > > --
> > > > Carlos Santana
> > > > <cs...@gmail.com>
> > > >
> > >
> >
> >
> >
> > --
> > Carlos Santana
> > <cs...@gmail.com>
> >
>
--
Carlos Santana
<cs...@gmail.com>
Re: CB-4900 device-orientation windows8 code review?
Posted by Jesse <pu...@gmail.com>.
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-device-orientation.git;a=commit;h=9d32a18404d5fefb609f4e844f955be426b6773d
@purplecabbage
risingj.com
On Wed, Sep 25, 2013 at 10:47 AM, Carlos Santana <cs...@gmail.com>wrote:
> will do
>
>
>
> On Wed, Sep 25, 2013 at 1:40 PM, Jesse <pu...@gmail.com> wrote:
>
> > It's good, I'd pull it in, but there are merge issues.
> > Can you update to include the latest commits to the dev branch?
> >
> > @purplecabbage
> > risingj.com
> >
> >
> > On Wed, Sep 25, 2013 at 10:12 AM, Carlos Santana <csantana23@gmail.com
> > >wrote:
> >
> > > Can someone review this proposed fix and if OK merge into dev?
> > >
> > > Windows 8 Compass plugin have extra define breaks plugin loading:
> > >
> > > https://issues.apache.org/jira/browse/CB-4900
> > >
> > > https://github.com/apache/cordova-plugin-device-orientation/pull/3
> > >
> > > --
> > > Carlos Santana
> > > <cs...@gmail.com>
> > >
> >
>
>
>
> --
> Carlos Santana
> <cs...@gmail.com>
>
Re: CB-4900 device-orientation windows8 code review?
Posted by Carlos Santana <cs...@gmail.com>.
will do
On Wed, Sep 25, 2013 at 1:40 PM, Jesse <pu...@gmail.com> wrote:
> It's good, I'd pull it in, but there are merge issues.
> Can you update to include the latest commits to the dev branch?
>
> @purplecabbage
> risingj.com
>
>
> On Wed, Sep 25, 2013 at 10:12 AM, Carlos Santana <csantana23@gmail.com
> >wrote:
>
> > Can someone review this proposed fix and if OK merge into dev?
> >
> > Windows 8 Compass plugin have extra define breaks plugin loading:
> >
> > https://issues.apache.org/jira/browse/CB-4900
> >
> > https://github.com/apache/cordova-plugin-device-orientation/pull/3
> >
> > --
> > Carlos Santana
> > <cs...@gmail.com>
> >
>
--
Carlos Santana
<cs...@gmail.com>
Re: CB-4900 device-orientation windows8 code review?
Posted by Jesse <pu...@gmail.com>.
It's good, I'd pull it in, but there are merge issues.
Can you update to include the latest commits to the dev branch?
@purplecabbage
risingj.com
On Wed, Sep 25, 2013 at 10:12 AM, Carlos Santana <cs...@gmail.com>wrote:
> Can someone review this proposed fix and if OK merge into dev?
>
> Windows 8 Compass plugin have extra define breaks plugin loading:
>
> https://issues.apache.org/jira/browse/CB-4900
>
> https://github.com/apache/cordova-plugin-device-orientation/pull/3
>
> --
> Carlos Santana
> <cs...@gmail.com>
>