You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/10/22 06:50:45 UTC

[GitHub] [kylin] zhangayqian opened a new pull request #1458: KYLIN-4793 In some Hadoop versions, kylin calcite reported error beca…

zhangayqian opened a new pull request #1458:
URL: https://github.com/apache/kylin/pull/1458


   …use there is no guava14
   
   ## Proposed changes
   
   Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
   
   ## Types of changes
   
   What types of changes does your code introduce to Kylin?
   _Put an `x` in the boxes that apply_
   
   - [x] Bugfix (non-breaking change which fixes an issue)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
   - [ ] Documentation Update (if none of the other choices apply)
   
   ## Checklist
   
   _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
   
   - [x] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail
   - [ ] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
   - [ ] Compiling and unit tests pass locally with my changes
   - [ ] I have added tests that prove my fix is effective or that my feature works
   - [ ] If this change need a document change, I will prepare another pr against the `document` branch
   - [ ] Any dependent changes have been merged
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kylin] zzcclp commented on pull request #1458: KYLIN-4793 In some Hadoop versions, kylin calcite reported error beca…

Posted by GitBox <gi...@apache.org>.
zzcclp commented on pull request #1458:
URL: https://github.com/apache/kylin/pull/1458#issuecomment-715094123


   LGTM, @hit-lacus please review.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kylin] zzcclp commented on a change in pull request #1458: KYLIN-4793 In some Hadoop versions, kylin calcite reported error beca…

Posted by GitBox <gi...@apache.org>.
zzcclp commented on a change in pull request #1458:
URL: https://github.com/apache/kylin/pull/1458#discussion_r510567639



##########
File path: build/bin/kylin.sh
##########
@@ -72,7 +72,14 @@ function retrieveDependency() {
     KYLIN_SPARK_JARS_HOME="${KYLIN_HOME}/spark/jars"
     if [[ -d "/usr/hdp/current/hdinsight-zookeeper" && $hdp_version == "2"* ]]
     then
-       echo "The current Hadoop environment is HDI3, will replace some jars package for ${KYLIN_HOME}/spark/jars"
+       echo "The current Hadoop environment is HDI3, will remove ${KYLIN_HOME}/tomcat/webapps/kylin/WEB-INF/lib/guava-14.0.jar and replace some jars package for ${KYLIN_HOME}/spark/jars"
+       unzip ${KYLIN_HOME}/tomcat/webapps/kylin.war
+       if [[ -f ${KYLIN_HOME}/tomcat/webapps/kylin/WEB-INF/lib/guava-14.0.jar ]]
+       then
+          rm -rf ${KYLIN_HOME}/tomcat/webapps/kylin/WEB-INF/lib/guava-14.0.jar
+          jar -cvfM0 ${KYLIN_HOME}/tomcat/webapps/kylin.war ${KYLIN_HOME}/tomcat/webapps/kylin/

Review comment:
       IMO, don't need to re-war this package.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kylin] hit-lacus merged pull request #1458: KYLIN-4793 In some Hadoop versions, kylin calcite reported error beca…

Posted by GitBox <gi...@apache.org>.
hit-lacus merged pull request #1458:
URL: https://github.com/apache/kylin/pull/1458


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kylin] zhangayqian commented on a change in pull request #1458: KYLIN-4793 In some Hadoop versions, kylin calcite reported error beca…

Posted by GitBox <gi...@apache.org>.
zhangayqian commented on a change in pull request #1458:
URL: https://github.com/apache/kylin/pull/1458#discussion_r510668060



##########
File path: build/bin/kylin.sh
##########
@@ -72,7 +72,14 @@ function retrieveDependency() {
     KYLIN_SPARK_JARS_HOME="${KYLIN_HOME}/spark/jars"
     if [[ -d "/usr/hdp/current/hdinsight-zookeeper" && $hdp_version == "2"* ]]
     then
-       echo "The current Hadoop environment is HDI3, will replace some jars package for ${KYLIN_HOME}/spark/jars"
+       echo "The current Hadoop environment is HDI3, will remove ${KYLIN_HOME}/tomcat/webapps/kylin/WEB-INF/lib/guava-14.0.jar and replace some jars package for ${KYLIN_HOME}/spark/jars"
+       unzip ${KYLIN_HOME}/tomcat/webapps/kylin.war
+       if [[ -f ${KYLIN_HOME}/tomcat/webapps/kylin/WEB-INF/lib/guava-14.0.jar ]]
+       then
+          rm -rf ${KYLIN_HOME}/tomcat/webapps/kylin/WEB-INF/lib/guava-14.0.jar
+          jar -cvfM0 ${KYLIN_HOME}/tomcat/webapps/kylin.war ${KYLIN_HOME}/tomcat/webapps/kylin/

Review comment:
       I will delete kylin.war after decompression.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kylin] zzcclp commented on a change in pull request #1458: KYLIN-4793 In some Hadoop versions, kylin calcite reported error beca…

Posted by GitBox <gi...@apache.org>.
zzcclp commented on a change in pull request #1458:
URL: https://github.com/apache/kylin/pull/1458#discussion_r510567480



##########
File path: build/bin/kylin.sh
##########
@@ -72,7 +72,14 @@ function retrieveDependency() {
     KYLIN_SPARK_JARS_HOME="${KYLIN_HOME}/spark/jars"
     if [[ -d "/usr/hdp/current/hdinsight-zookeeper" && $hdp_version == "2"* ]]
     then
-       echo "The current Hadoop environment is HDI3, will replace some jars package for ${KYLIN_HOME}/spark/jars"
+       echo "The current Hadoop environment is HDI3, will remove ${KYLIN_HOME}/tomcat/webapps/kylin/WEB-INF/lib/guava-14.0.jar and replace some jars package for ${KYLIN_HOME}/spark/jars"
+       unzip ${KYLIN_HOME}/tomcat/webapps/kylin.war

Review comment:
       It's better to check whether exists unzip command, if not, echo some error message and exit.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kylin] zhangayqian commented on a change in pull request #1458: KYLIN-4793 In some Hadoop versions, kylin calcite reported error beca…

Posted by GitBox <gi...@apache.org>.
zhangayqian commented on a change in pull request #1458:
URL: https://github.com/apache/kylin/pull/1458#discussion_r510569197



##########
File path: build/bin/kylin.sh
##########
@@ -72,7 +72,14 @@ function retrieveDependency() {
     KYLIN_SPARK_JARS_HOME="${KYLIN_HOME}/spark/jars"
     if [[ -d "/usr/hdp/current/hdinsight-zookeeper" && $hdp_version == "2"* ]]
     then
-       echo "The current Hadoop environment is HDI3, will replace some jars package for ${KYLIN_HOME}/spark/jars"
+       echo "The current Hadoop environment is HDI3, will remove ${KYLIN_HOME}/tomcat/webapps/kylin/WEB-INF/lib/guava-14.0.jar and replace some jars package for ${KYLIN_HOME}/spark/jars"
+       unzip ${KYLIN_HOME}/tomcat/webapps/kylin.war

Review comment:
       My negligence. I wiil use `jar -xvf` to decompression kylin.war.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kylin] zhangayqian commented on pull request #1458: KYLIN-4793 In some Hadoop versions, kylin calcite reported error beca…

Posted by GitBox <gi...@apache.org>.
zhangayqian commented on pull request #1458:
URL: https://github.com/apache/kylin/pull/1458#issuecomment-714273721


   Commit https://github.com/apache/kylin/commit/e1fd472d00eea438d26c26f032e819db56e33486 remove guava14 from Kylin.war，which will causes calcite reported error because there is no guava14 in some Hadoop versions.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org