You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "SouthwestAsiaFloat (via GitHub)" <gi...@apache.org> on 2026/08/09 14:40:09 UTC

[PR] feat(triple): complete client construction chain [dubbo-go]

SouthwestAsiaFloat opened a new pull request, #3631:
URL: https://github.com/apache/dubbo-go/pull/3631

   ### Description
   
   Completes the Triple client construction chain by:
   
   - separating the responsibilities of `clientManager` and `tri.Client`;
   - centralizing HTTP/2, HTTP/3, and dual transport initialization;
   - clarifying how keepalive, TLS, and message size limits are propagated;
   - adding tests for transport initialization, keepalive resolution, size limits, and response metadata.
   
   this is a task from https://github.com/apache/dubbo-go/issues/3598
   
   ### Checklist
   
   - [x] I confirm the target branch is `develop`
   - [x] Code has passed local testing
   - [x] I have added tests that prove my fix is effective or that my feature works
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [PR] feat(triple): complete client construction chain [dubbo-go]

Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #3631:
URL: https://github.com/apache/dubbo-go/pull/3631#issuecomment-5232077228

   ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3631) **Quality Gate passed**  
   Issues  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [21 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3631&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png '') [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3631&issueStatuses=ACCEPTED)
   
   Measures  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=3631&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3631&metric=new_coverage&view=list)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [3.6% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3631&metric=new_duplicated_lines_density&view=list)  
     
   <!-- sqra-placement-anchor -->
   [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3631)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [PR] feat(triple): complete client construction chain [dubbo-go]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3631:
URL: https://github.com/apache/dubbo-go/pull/3631#issuecomment-5232100393

   ## [Codecov](https://app.codecov.io/gh/apache/dubbo-go/pull/3631?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `25.30756%` with `850 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 53.99%. Comparing base ([`48d6e69`](https://app.codecov.io/gh/apache/dubbo-go/commit/48d6e696e755d46df2425bbf71c413bbd1887f3f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`5a46b63`](https://app.codecov.io/gh/apache/dubbo-go/commit/5a46b6351d0d22cd8b27ee5b6162f8394695663e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/dubbo-go/pull/3631?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [tools/benchmark/client/main.go](https://app.codecov.io/gh/apache/dubbo-go/pull/3631?src=pr&el=tree&filepath=tools%2Fbenchmark%2Fclient%2Fmain.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dG9vbHMvYmVuY2htYXJrL2NsaWVudC9tYWluLmdv) | 0.00% | [149 Missing :warning: ](https://app.codecov.io/gh/apache/dubbo-go/pull/3631?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [tools/benchmark/client/monitor/system\_monitor.go](https://app.codecov.io/gh/apache/dubbo-go/pull/3631?src=pr&el=tree&filepath=tools%2Fbenchmark%2Fclient%2Fmonitor%2Fsystem_monitor.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dG9vbHMvYmVuY2htYXJrL2NsaWVudC9tb25pdG9yL3N5c3RlbV9tb25pdG9yLmdv) | 0.00% | [93 Missing :warning: ](https://app.codecov.io/gh/apache/dubbo-go/pull/3631?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [tools/benchmark/proto/benchmark.pb.go](https://app.codecov.io/gh/apache/dubbo-go/pull/3631?src=pr&el=tree&filepath=tools%2Fbenchmark%2Fproto%2Fbenchmark.pb.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dG9vbHMvYmVuY2htYXJrL3Byb3RvL2JlbmNobWFyay5wYi5nbw==) | 0.00% | [70 Missing :warning: ](https://app.codecov.io/gh/apache/dubbo-go/pull/3631?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [tools/benchmark/proto/benchmark.triple.go](https://app.codecov.io/gh/apache/dubbo-go/pull/3631?src=pr&el=tree&filepath=tools%2Fbenchmark%2Fproto%2Fbenchmark.triple.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dG9vbHMvYmVuY2htYXJrL3Byb3RvL2JlbmNobWFyay50cmlwbGUuZ28=) | 0.00% | [66 Missing :warning: ](https://app.codecov.io/gh/apache/dubbo-go/pull/3631?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [tools/benchmark/client/engine/engine.go](https://app.codecov.io/gh/apache/dubbo-go/pull/3631?src=pr&el=tree&filepath=tools%2Fbenchmark%2Fclient%2Fengine%2Fengine.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dG9vbHMvYmVuY2htYXJrL2NsaWVudC9lbmdpbmUvZW5naW5lLmdv) | 0.00% | [53 Missing :warning: ](https://app.codecov.io/gh/apache/dubbo-go/pull/3631?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [tools/benchmark/client/clients/dubbo\_client.go](https://app.codecov.io/gh/apache/dubbo-go/pull/3631?src=pr&el=tree&filepath=tools%2Fbenchmark%2Fclient%2Fclients%2Fdubbo_client.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dG9vbHMvYmVuY2htYXJrL2NsaWVudC9jbGllbnRzL2R1YmJvX2NsaWVudC5nbw==) | 0.00% | [51 Missing :warning: ](https://app.codecov.io/gh/apache/dubbo-go/pull/3631?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [tools/benchmark/client/engine/statistics.go](https://app.codecov.io/gh/apache/dubbo-go/pull/3631?src=pr&el=tree&filepath=tools%2Fbenchmark%2Fclient%2Fengine%2Fstatistics.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dG9vbHMvYmVuY2htYXJrL2NsaWVudC9lbmdpbmUvc3RhdGlzdGljcy5nbw==) | 0.00% | [50 Missing :warning: ](https://app.codecov.io/gh/apache/dubbo-go/pull/3631?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [tools/benchmark/server/dubbo-go/main.go](https://app.codecov.io/gh/apache/dubbo-go/pull/3631?src=pr&el=tree&filepath=tools%2Fbenchmark%2Fserver%2Fdubbo-go%2Fmain.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dG9vbHMvYmVuY2htYXJrL3NlcnZlci9kdWJiby1nby9tYWluLmdv) | 0.00% | [48 Missing :warning: ](https://app.codecov.io/gh/apache/dubbo-go/pull/3631?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [tools/benchmark/proto/benchmark\_grpc.pb.go](https://app.codecov.io/gh/apache/dubbo-go/pull/3631?src=pr&el=tree&filepath=tools%2Fbenchmark%2Fproto%2Fbenchmark_grpc.pb.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dG9vbHMvYmVuY2htYXJrL3Byb3RvL2JlbmNobWFya19ncnBjLnBiLmdv) | 0.00% | [40 Missing :warning: ](https://app.codecov.io/gh/apache/dubbo-go/pull/3631?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [tools/benchmark/client/clients/grpc\_client.go](https://app.codecov.io/gh/apache/dubbo-go/pull/3631?src=pr&el=tree&filepath=tools%2Fbenchmark%2Fclient%2Fclients%2Fgrpc_client.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dG9vbHMvYmVuY2htYXJrL2NsaWVudC9jbGllbnRzL2dycGNfY2xpZW50Lmdv) | 0.00% | [37 Missing :warning: ](https://app.codecov.io/gh/apache/dubbo-go/pull/3631?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | ... and [18 more](https://app.codecov.io/gh/apache/dubbo-go/pull/3631?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@            Coverage Diff             @@
   ##             main    #3631      +/-   ##
   ==========================================
   - Coverage   54.57%   53.99%   -0.59%     
   ==========================================
     Files         460      474      +14     
     Lines       35443    36393     +950     
   ==========================================
   + Hits        19344    19649     +305     
   - Misses      14543    15162     +619     
   - Partials     1556     1582      +26     
   ```
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/dubbo-go/pull/3631?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [PR] feat(triple): complete client construction chain [dubbo-go]

Posted by "SouthwestAsiaFloat (via GitHub)" <gi...@apache.org>.
SouthwestAsiaFloat closed pull request #3631: feat(triple): complete client construction chain
URL: https://github.com/apache/dubbo-go/pull/3631


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org