[GitHub] [incubator-inlong] yunqingmoswu commented on a change in pull request #3038: [INLONG-3037][Manager] Add field mapping support for source and sink in manage client

[GitBox <gi...@apache.org>]

yunqingmoswu commented on a change in pull request #3038:
URL: https://github.com/apache/incubator-inlong/pull/3038#discussion_r823371671



##########
File path: inlong-manager/manager-client/src/main/java/org/apache/inlong/manager/client/api/sink/ClickHouseSink.java
##########
@@ -79,7 +78,7 @@
     private boolean needCreated;
 
     @ApiModelProperty("Field definitions for kafka")

Review comment:
       done

##########
File path: inlong-manager/manager-client/src/main/java/org/apache/inlong/manager/client/api/sink/KafkaSink.java
##########
@@ -19,18 +19,17 @@
 
 import io.swagger.annotations.ApiModel;
 import io.swagger.annotations.ApiModelProperty;
+import java.util.List;
+import java.util.Map;
 import lombok.AllArgsConstructor;
 import lombok.Data;
 import lombok.EqualsAndHashCode;
 import lombok.NoArgsConstructor;
 import org.apache.inlong.manager.client.api.DataFormat;
-import org.apache.inlong.manager.client.api.StreamField;
+import org.apache.inlong.manager.client.api.SinkField;
 import org.apache.inlong.manager.client.api.StreamSink;
 import org.apache.inlong.manager.common.enums.SinkType;
 
-import java.util.List;

Review comment:
       done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org