[jira] Updated: (SOLR-993) VariableResolverImpl addNamespace overwrites entire namespace instead of adding

["Jared Flatow (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SOLR-993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jared Flatow updated SOLR-993:
------------------------------

    Attachment: SOLR-993b.patch

I am confused by the implementation of namespaces in the VariableResolverImpl. Why are they implemented as chained hashmaps and not flat? The remove method seems to treat them as flat, which seems totally inconsistent? Why does DocBuilder have on line 355:

{code:java}
if (isRoot)
 vr.removeNamespace(null);
{code}

What is this supposed to accomplish?

I have attempted to patch the implementation with what I believe is the desired behavior. I added an addToNamespace function as well.
 

> VariableResolverImpl addNamespace overwrites entire namespace instead of adding
> -------------------------------------------------------------------------------
>
>                 Key: SOLR-993
>                 URL: https://issues.apache.org/jira/browse/SOLR-993
>             Project: Solr
>          Issue Type: Bug
>          Components: contrib - DataImportHandler
>    Affects Versions: 1.4
>            Reporter: Jared Flatow
>             Fix For: 1.4
>
>         Attachments: SOLR-993.patch, SOLR-993b.patch
>
>   Original Estimate: 0.08h
>  Remaining Estimate: 0.08h
>
> The addNamespace method in VariableResolverImpl does not so much add the namespace as overwrite it. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.