[GitHub] [james-project] vttranlina commented on a diff in pull request #1491: [FIX] Subscribe/unsubscribe mailbox should be per user based

["vttranlina (via GitHub)" <gi...@apache.org>]

vttranlina commented on code in PR #1491:
URL: https://github.com/apache/james-project/pull/1491#discussion_r1141621823


##########
server/protocols/jmap-rfc-8621-integration-tests/jmap-rfc-8621-integration-tests-common/src/main/scala/org/apache/james/jmap/rfc8621/contract/MailboxChangesMethodContract.scala:
##########
@@ -1023,6 +1023,70 @@ trait MailboxChangesMethodContract {
       }
     }
 
+    @Test
+    def mailboxChangesShouldReturnUpdatedChangesWhenSubscribedOnlyPerUser(server: GuiceJamesServer): Unit = {

Review Comment:
   For another user (Andre)
   After Bob receives the changed `"updated": ["BobMailbox1"]`
   We can change AndreMailbox1, and AwaitUntil the test for ensuring Andre Mailbox changes only AndreMailbox1 (does not contain BobMailbox1)
   
   It not sure 100%, but it will be more trusty 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org