You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Chris Douglas (JIRA)" <ji...@apache.org> on 2010/10/05 04:28:32 UTC

[jira] Created: (HADOOP-6991) SequenceFile::Reader discards length for files, does not call openFile

SequenceFile::Reader discards length for files, does not call openFile
----------------------------------------------------------------------

                 Key: HADOOP-6991
                 URL: https://issues.apache.org/jira/browse/HADOOP-6991
             Project: Hadoop Common
          Issue Type: Bug
    Affects Versions: 0.22.0
            Reporter: Chris Douglas
            Priority: Minor


While the sorting and merging in {{SequenceFile}} is deprecated and {{openFile}} is archaic, the semantics should remain consistent.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6991) SequenceFile::Reader discards length for files, does not call openFile

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925950#action_12925950 ] 

Hudson commented on HADOOP-6991:
--------------------------------

Integrated in Hadoop-Common-trunk-Commit #407 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/407/])
    HADOOP-6991.  Fix SequenceFile::Reader to honor file lengths and call
openFile (cdouglas via omalley)


> SequenceFile::Reader discards length for files, does not call openFile
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-6991
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6991
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Chris Douglas
>            Assignee: Chris Douglas
>            Priority: Minor
>             Fix For: 0.22.0
>
>         Attachments: 6991-0.patch, 6991-1.patch, h-6991-2.patch
>
>
> While the sorting and merging in {{SequenceFile}} is deprecated and {{openFile}} is archaic, the semantics should remain consistent.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6991) SequenceFile::Reader discards length for files, does not call openFile

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924817#action_12924817 ] 

Chris Douglas commented on HADOOP-6991:
---------------------------------------

+1

Ran the {{SequenceFile*}} unit tests in MapReduce, all passed.

> SequenceFile::Reader discards length for files, does not call openFile
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-6991
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6991
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Chris Douglas
>            Priority: Minor
>         Attachments: 6991-0.patch, 6991-1.patch, h-6991-2.patch
>
>
> While the sorting and merging in {{SequenceFile}} is deprecated and {{openFile}} is archaic, the semantics should remain consistent.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6991) SequenceFile::Reader discards length for files, does not call openFile

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12926101#action_12926101 ] 

Hudson commented on HADOOP-6991:
--------------------------------

Integrated in Hadoop-Mapreduce-trunk-Commit #523 (See [https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/523/])
    

> SequenceFile::Reader discards length for files, does not call openFile
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-6991
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6991
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Chris Douglas
>            Assignee: Chris Douglas
>            Priority: Minor
>             Fix For: 0.22.0
>
>         Attachments: 6991-0.patch, 6991-1.patch, h-6991-2.patch
>
>
> While the sorting and merging in {{SequenceFile}} is deprecated and {{openFile}} is archaic, the semantics should remain consistent.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6991) SequenceFile::Reader discards length for files, does not call openFile

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Owen O'Malley updated HADOOP-6991:
----------------------------------

    Attachment:     (was: h-6991-2.patch)

> SequenceFile::Reader discards length for files, does not call openFile
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-6991
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6991
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Chris Douglas
>            Priority: Minor
>         Attachments: 6991-0.patch, 6991-1.patch, h-6991-2.patch
>
>
> While the sorting and merging in {{SequenceFile}} is deprecated and {{openFile}} is archaic, the semantics should remain consistent.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6991) SequenceFile::Reader discards length for files, does not call openFile

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Owen O'Malley updated HADOOP-6991:
----------------------------------

    Attachment: h-6991-2.patch

Forgot test case.

> SequenceFile::Reader discards length for files, does not call openFile
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-6991
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6991
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Chris Douglas
>            Priority: Minor
>         Attachments: 6991-0.patch, 6991-1.patch, h-6991-2.patch
>
>
> While the sorting and merging in {{SequenceFile}} is deprecated and {{openFile}} is archaic, the semantics should remain consistent.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6991) SequenceFile::Reader discards length for files, does not call openFile

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas updated HADOOP-6991:
----------------------------------

    Attachment: 6991-0.patch

> SequenceFile::Reader discards length for files, does not call openFile
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-6991
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6991
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Chris Douglas
>            Priority: Minor
>         Attachments: 6991-0.patch
>
>
> While the sorting and merging in {{SequenceFile}} is deprecated and {{openFile}} is archaic, the semantics should remain consistent.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6991) SequenceFile::Reader discards length for files, does not call openFile

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas updated HADOOP-6991:
----------------------------------

    Status: Patch Available  (was: Open)

> SequenceFile::Reader discards length for files, does not call openFile
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-6991
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6991
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Chris Douglas
>            Priority: Minor
>         Attachments: 6991-0.patch, 6991-1.patch
>
>
> While the sorting and merging in {{SequenceFile}} is deprecated and {{openFile}} is archaic, the semantics should remain consistent.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6991) SequenceFile::Reader discards length for files, does not call openFile

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Owen O'Malley updated HADOOP-6991:
----------------------------------

    Attachment: h-6991-2.patch

Updated Chris' patch with the test case moved from MapRed and turning on overwrite.

> SequenceFile::Reader discards length for files, does not call openFile
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-6991
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6991
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Chris Douglas
>            Priority: Minor
>         Attachments: 6991-0.patch, 6991-1.patch, h-6991-2.patch
>
>
> While the sorting and merging in {{SequenceFile}} is deprecated and {{openFile}} is archaic, the semantics should remain consistent.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6991) SequenceFile::Reader discards length for files, does not call openFile

Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Douglas updated HADOOP-6991:
----------------------------------

    Attachment: 6991-1.patch

Patch on top of HADOOP-6984

> SequenceFile::Reader discards length for files, does not call openFile
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-6991
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6991
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Chris Douglas
>            Priority: Minor
>         Attachments: 6991-0.patch, 6991-1.patch
>
>
> While the sorting and merging in {{SequenceFile}} is deprecated and {{openFile}} is archaic, the semantics should remain consistent.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HADOOP-6991) SequenceFile::Reader discards length for files, does not call openFile

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Owen O'Malley reassigned HADOOP-6991:
-------------------------------------

    Assignee: Chris Douglas

> SequenceFile::Reader discards length for files, does not call openFile
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-6991
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6991
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Chris Douglas
>            Assignee: Chris Douglas
>            Priority: Minor
>         Attachments: 6991-0.patch, 6991-1.patch, h-6991-2.patch
>
>
> While the sorting and merging in {{SequenceFile}} is deprecated and {{openFile}} is archaic, the semantics should remain consistent.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-6991) SequenceFile::Reader discards length for files, does not call openFile

Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-6991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Owen O'Malley updated HADOOP-6991:
----------------------------------

       Resolution: Fixed
    Fix Version/s: 0.22.0
     Hadoop Flags: [Reviewed]
           Status: Resolved  (was: Patch Available)

I just committed this. Thanks, Chris!

> SequenceFile::Reader discards length for files, does not call openFile
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-6991
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6991
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Chris Douglas
>            Assignee: Chris Douglas
>            Priority: Minor
>             Fix For: 0.22.0
>
>         Attachments: 6991-0.patch, 6991-1.patch, h-6991-2.patch
>
>
> While the sorting and merging in {{SequenceFile}} is deprecated and {{openFile}} is archaic, the semantics should remain consistent.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-6991) SequenceFile::Reader discards length for files, does not call openFile

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-6991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12926239#action_12926239 ] 

Hudson commented on HADOOP-6991:
--------------------------------

Integrated in Hadoop-Common-trunk #496 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/496/])
    HADOOP-6991.  Fix SequenceFile::Reader to honor file lengths and call
openFile (cdouglas via omalley)
HADOOP-6991. Move testcase from mapreduce to common, since it tests 
SequenceFile.


> SequenceFile::Reader discards length for files, does not call openFile
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-6991
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6991
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Chris Douglas
>            Assignee: Chris Douglas
>            Priority: Minor
>             Fix For: 0.22.0
>
>         Attachments: 6991-0.patch, 6991-1.patch, h-6991-2.patch
>
>
> While the sorting and merging in {{SequenceFile}} is deprecated and {{openFile}} is archaic, the semantics should remain consistent.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.