[jira] Commented: (PIG-713) Autocompletion doesn't complete aliases

["Alan Gates (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PIG-713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12689214#action_12689214 ] 

Alan Gates commented on PIG-713:
--------------------------------

Patch looks good to me.  I downloaded it and played with it a bit.  Passed all the tests and seemed to work well.  I particularly like the way it only provides alias completion in a meaningful context (in locations where you'd expect an alias and not on the left side of an assignment where it wouldn't make sense to be using an existing alias).

Daniel, did you want to review this before it's checked in, as you did the original jline work?

> Autocompletion doesn't complete aliases
> ---------------------------------------
>
>                 Key: PIG-713
>                 URL: https://issues.apache.org/jira/browse/PIG-713
>             Project: Pig
>          Issue Type: New Feature
>          Components: grunt
>            Reporter: Eric Gaudet
>            Priority: Minor
>         Attachments: alias_completion.patch
>
>
> Autocompletion only knows about keywords, but in different contexts, it would be nice if it completed aliases where an alias is expected.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.