You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@carbondata.apache.org by ja...@apache.org on 2019/11/04 08:33:30 UTC
[carbondata] branch master updated: [CARBONDATA-3564] optimize java
code checkstyle for EmptyStatement rule
This is an automated email from the ASF dual-hosted git repository.
jackylk pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/carbondata.git
The following commit(s) were added to refs/heads/master by this push:
new a1b13e1 [CARBONDATA-3564] optimize java code checkstyle for EmptyStatement rule
a1b13e1 is described below
commit a1b13e17de2fb54256aeae5439f1a539c1bc5434
Author: lamber-ken <22...@qq.com>
AuthorDate: Fri Nov 1 10:25:35 2019 +0800
[CARBONDATA-3564] optimize java code checkstyle for EmptyStatement rule
This closes #3429
---
.../impl/unsafe/UnsafeVariableLengthDimensionDataChunkStore.java | 2 +-
.../java/org/apache/carbondata/core/metadata/SegmentFileStore.java | 2 +-
.../core/metadata/schema/table/DiskBasedDMSchemaStorageProvider.java | 2 +-
.../java/org/apache/carbondata/core/profiler/TablePruningInfo.java | 4 ++--
.../apache/carbondata/datamap/lucene/LuceneDataMapFactoryBase.java | 2 +-
.../java/org/apache/carbondata/processing/util/CarbonLoaderUtil.java | 2 +-
6 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/unsafe/UnsafeVariableLengthDimensionDataChunkStore.java b/core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/unsafe/UnsafeVariableLengthDimensionDataChunkStore.java
index 8d2f623..12db348 100644
--- a/core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/unsafe/UnsafeVariableLengthDimensionDataChunkStore.java
+++ b/core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/unsafe/UnsafeVariableLengthDimensionDataChunkStore.java
@@ -246,7 +246,7 @@ public abstract class UnsafeVariableLengthDimensionDataChunkStore
*/
@Override
public int compareTo(int rowId, byte[] compareValue) {
- int currentDataOffset = getOffSet(rowId);;
+ int currentDataOffset = getOffSet(rowId);
int length = getLength(rowId, currentDataOffset);
// as this class handles this variable length data, so filter value can be
// smaller or bigger than than actual data, so we need to take the smaller length
diff --git a/core/src/main/java/org/apache/carbondata/core/metadata/SegmentFileStore.java b/core/src/main/java/org/apache/carbondata/core/metadata/SegmentFileStore.java
index 2f71bbc..511687e 100644
--- a/core/src/main/java/org/apache/carbondata/core/metadata/SegmentFileStore.java
+++ b/core/src/main/java/org/apache/carbondata/core/metadata/SegmentFileStore.java
@@ -491,7 +491,7 @@ public class SegmentFileStore {
LOGGER.error(
"Not able to acquire the lock for Table status updation for table path " + tablePath);
}
- ;
+
} finally {
if (carbonLock.unlock()) {
LOGGER.info("Table unlocked successfully after table status updation" + tablePath);
diff --git a/core/src/main/java/org/apache/carbondata/core/metadata/schema/table/DiskBasedDMSchemaStorageProvider.java b/core/src/main/java/org/apache/carbondata/core/metadata/schema/table/DiskBasedDMSchemaStorageProvider.java
index b8149cc..a430662 100644
--- a/core/src/main/java/org/apache/carbondata/core/metadata/schema/table/DiskBasedDMSchemaStorageProvider.java
+++ b/core/src/main/java/org/apache/carbondata/core/metadata/schema/table/DiskBasedDMSchemaStorageProvider.java
@@ -220,7 +220,7 @@ public class DiskBasedDMSchemaStorageProvider implements DataMapSchemaStoragePro
*/
public static String getSchemaPath(String storePath, String dataMapName) {
String schemaPath = storePath + CarbonCommonConstants.FILE_SEPARATOR + dataMapName
- + ".dmschema";;
+ + ".dmschema";
return schemaPath;
}
}
diff --git a/core/src/main/java/org/apache/carbondata/core/profiler/TablePruningInfo.java b/core/src/main/java/org/apache/carbondata/core/profiler/TablePruningInfo.java
index 826329a..424d7c7 100644
--- a/core/src/main/java/org/apache/carbondata/core/profiler/TablePruningInfo.java
+++ b/core/src/main/java/org/apache/carbondata/core/profiler/TablePruningInfo.java
@@ -107,7 +107,7 @@ public class TablePruningInfo {
.append(" - name: ").append(cgDataMap.getDataMapWrapperName()).append("\n")
.append(" - provider: ").append(cgDataMap.getDataMapWrapperProvider()).append("\n")
.append(" - skipped: ").append(skipBlocks).append(" blocks, ")
- .append(skipBlocklets).append(" blocklets").append("\n");;
+ .append(skipBlocklets).append(" blocklets").append("\n");
}
if (fgDataMap != null) {
if (numBlockletsAfterCGPruning != 0) {
@@ -122,7 +122,7 @@ public class TablePruningInfo {
.append(" - name: ").append(fgDataMap.getDataMapWrapperName()).append("\n")
.append(" - provider: ").append(fgDataMap.getDataMapWrapperProvider()).append("\n")
.append(" - skipped: ").append(skipBlocks).append(" blocks, ")
- .append(skipBlocklets).append(" blocklets").append("\n");;
+ .append(skipBlocklets).append(" blocklets").append("\n");
}
return builder.toString();
} else {
diff --git a/datamap/lucene/src/main/java/org/apache/carbondata/datamap/lucene/LuceneDataMapFactoryBase.java b/datamap/lucene/src/main/java/org/apache/carbondata/datamap/lucene/LuceneDataMapFactoryBase.java
index 88c6969..1f97fe0 100644
--- a/datamap/lucene/src/main/java/org/apache/carbondata/datamap/lucene/LuceneDataMapFactoryBase.java
+++ b/datamap/lucene/src/main/java/org/apache/carbondata/datamap/lucene/LuceneDataMapFactoryBase.java
@@ -126,7 +126,7 @@ abstract class LuceneDataMapFactoryBase<T extends DataMap> extends DataMapFactor
this.dataMapName = dataMapSchema.getDataMapName();
// validate DataMapSchema and get index columns
- indexedCarbonColumns = carbonTable.getIndexedColumns(dataMapSchema);;
+ indexedCarbonColumns = carbonTable.getIndexedColumns(dataMapSchema);
flushCacheSize = validateAndGetWriteCacheSize(dataMapSchema);
storeBlockletWise = validateAndGetStoreBlockletWise(dataMapSchema);
diff --git a/processing/src/main/java/org/apache/carbondata/processing/util/CarbonLoaderUtil.java b/processing/src/main/java/org/apache/carbondata/processing/util/CarbonLoaderUtil.java
index 8aafed9..3e4768e 100644
--- a/processing/src/main/java/org/apache/carbondata/processing/util/CarbonLoaderUtil.java
+++ b/processing/src/main/java/org/apache/carbondata/processing/util/CarbonLoaderUtil.java
@@ -374,7 +374,7 @@ public final class CarbonLoaderUtil {
} else {
LOGGER.error("Not able to acquire the lock for Table status updation for table " + loadModel
.getDatabaseName() + "." + loadModel.getTableName());
- };
+ }
} finally {
if (carbonLock.unlock()) {
LOGGER.info(