You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2022/04/26 19:30:33 UTC

[GitHub] [geode] pivotal-jbarrett commented on pull request #7621: GEODE-10036: remove need to export sun.nio.ch

pivotal-jbarrett commented on PR #7621:
URL: https://github.com/apache/geode/pull/7621#issuecomment-1110170895

   @dschneider-pivotal I believe the original intent on using the hidden direct buffer method was to avoid the allocation of yet another transient object. More transient allocations in the hot path of p2p communication could have negative performance impacts. Honestly the fact that we had to return a specifically sized slice back from the pool was a concerning smell to me. Perhaps there is a way to solve this by just returning the actual buffer with just the limit set.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org