[jira] [Commented] (THRIFT-3263) PHP jsonSerialize() should cast scalar types

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14639695#comment-14639695 ] 

ASF GitHub Bot commented on THRIFT-3263:
----------------------------------------

GitHub user stigsb opened a pull request:

    https://github.com/apache/thrift/pull/560

    PHP Compiler: always cast scalar types in jsonSerialize()

    In PHP, values from databases and such are usually always strings, so it is useful to cast values during JSON serialization to maintain the Thrift schema's types.
    
    THRIFT-3263

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/stigsb/thrift php_jsonserialize_casting

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/560.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #560
    
----
commit 178953910c18d36ebf16daaa3497123cec77b022
Author: Stig Bakken <st...@zedge.net>
Date:   2015-07-23T23:41:33Z

    PHP Compiler: always cast scalar types in jsonSerialize()

----


> PHP jsonSerialize() should cast scalar types
> --------------------------------------------
>
>                 Key: THRIFT-3263
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3263
>             Project: Thrift
>          Issue Type: Improvement
>          Components: PHP - Compiler
>    Affects Versions: 0.9.2
>            Reporter: Stig Bakken
>            Priority: Minor
>
> In PHP, values from databases and such are usually always strings, so it is useful to cast values during JSON serialization to maintain the Thrift schema's types.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)