You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Pranav Saxena <pr...@citrix.com> on 2012/07/04 20:27:34 UTC
Review Request: CS-13376:Vm is stuck in Stopping state when MS is rebooted
after the stop command was issued but answer wasn't recieved from the
backend yet
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5762/
-----------------------------------------------------------
Review request for cloudstack and Abhinandan Prateek.
Description
-------
1) Have just 1 xen host.
2) Have user VMs running on the backend.
3) Issue Stop command and allow it to reach the backend but stop MS before answer comes back
4) start the management server.
VM is stuck in Stopping state after restarting the management server
This addresses bug CS-13376.
Diffs
-----
server/src/com/cloud/vm/VirtualMachineManagerImpl.java 561e5b290c8bf5e9e319e3588535041426530c5f
Diff: https://reviews.apache.org/r/5762/diff/
Testing
-------
Debugged the code by putting system.exit statements to track the response from the backend and thereby tested it on my local cloudstack set up.
Thanks,
Pranav Saxena
Re: Review Request: CS-13376:Vm is stuck in Stopping state when MS is
rebooted after the stop command was issued but answer wasn't recieved from
the backend yet
Posted by Koushik Das <ko...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5762/#review8877
-----------------------------------------------------------
The 'else' condition checks for (info == null) but info is getting used inside the block. This will result NP exception.
- Koushik Das
On July 4, 2012, 6:27 p.m., Pranav Saxena wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5762/
> -----------------------------------------------------------
>
> (Updated July 4, 2012, 6:27 p.m.)
>
>
> Review request for cloudstack and Abhinandan Prateek.
>
>
> Description
> -------
>
>
> 1) Have just 1 xen host.
> 2) Have user VMs running on the backend.
> 3) Issue Stop command and allow it to reach the backend but stop MS before answer comes back
> 4) start the management server.
>
> VM is stuck in Stopping state after restarting the management server
>
>
> This addresses bug CS-13376.
>
>
> Diffs
> -----
>
> server/src/com/cloud/vm/VirtualMachineManagerImpl.java 561e5b290c8bf5e9e319e3588535041426530c5f
>
> Diff: https://reviews.apache.org/r/5762/diff/
>
>
> Testing
> -------
>
> Debugged the code by putting system.exit statements to track the response from the backend and thereby tested it on my local cloudstack set up.
>
>
> Thanks,
>
> Pranav Saxena
>
>