You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by "Adam Heath (JIRA)" <ji...@apache.org> on 2007/05/14 16:34:16 UTC
[jira] Created: (VFS-148) Make DefaultFileSelectInfo public
Make DefaultFileSelectInfo public
---------------------------------
Key: VFS-148
URL: https://issues.apache.org/jira/browse/VFS-148
Project: Commons VFS
Issue Type: New Feature
Affects Versions: 1.1
Reporter: Adam Heath
Priority: Trivial
Attachments: feature_DefaultFileSelectorInfo_public.patch
See $summary, and patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Commented: (VFS-148) Make DefaultFileSelectInfo public
Posted by "Mario Ivankovits (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VFS-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495716 ]
Mario Ivankovits commented on VFS-148:
--------------------------------------
Whats the reason for making it public??
This allows one to cast the passed FileSelectInfo to the DefaultfileSelectorInfo class and call one of the set* methods.
Which is not what we want during traversing ... no?
> Make DefaultFileSelectInfo public
> ---------------------------------
>
> Key: VFS-148
> URL: https://issues.apache.org/jira/browse/VFS-148
> Project: Commons VFS
> Issue Type: New Feature
> Affects Versions: 1.1
> Reporter: Adam Heath
> Priority: Trivial
> Attachments: feature_DefaultFileSelectorInfo_public.patch
>
>
> See $summary, and patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Commented: (VFS-148) Make DefaultFileSelectInfo public
Posted by "Mario Ivankovits (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VFS-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495757 ]
Mario Ivankovits commented on VFS-148:
--------------------------------------
With "other walking capabilities" you mean stuff outside of VFS?
AbstractFileObject.traverse() itself is private, so you never could use the DefaultFileSelectorInfo with any public/protected VFS api.
> Make DefaultFileSelectInfo public
> ---------------------------------
>
> Key: VFS-148
> URL: https://issues.apache.org/jira/browse/VFS-148
> Project: Commons VFS
> Issue Type: New Feature
> Affects Versions: 1.1
> Reporter: Adam Heath
> Priority: Trivial
> Attachments: feature_DefaultFileSelectorInfo_public.patch
>
>
> See $summary, and patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Updated: (VFS-148) Make DefaultFileSelectInfo public
Posted by "Adam Heath (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VFS-148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adam Heath updated VFS-148:
---------------------------
Attachment: feature_DefaultFileSelectorInfo_public.patch
Against svn 501759.
> Make DefaultFileSelectInfo public
> ---------------------------------
>
> Key: VFS-148
> URL: https://issues.apache.org/jira/browse/VFS-148
> Project: Commons VFS
> Issue Type: New Feature
> Affects Versions: 1.1
> Reporter: Adam Heath
> Priority: Trivial
> Attachments: feature_DefaultFileSelectorInfo_public.patch
>
>
> See $summary, and patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Commented: (VFS-148) Make DefaultFileSelectInfo public
Posted by "Adam Heath (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VFS-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495754 ]
Adam Heath commented on VFS-148:
--------------------------------
It also prevents other code from instantiating this class itself, for implementing other walking capabilities. This other code would have to implement FileSelectInfo itself, instead of just overriding this code, and slightly changing it.
It's a minor change, and I do understand if you don't want to accept it. If you really want to protect those set methods, then a better way, imho, is to use an internal class(not a separate class in a separate file), or to make the methods package protected.
> Make DefaultFileSelectInfo public
> ---------------------------------
>
> Key: VFS-148
> URL: https://issues.apache.org/jira/browse/VFS-148
> Project: Commons VFS
> Issue Type: New Feature
> Affects Versions: 1.1
> Reporter: Adam Heath
> Priority: Trivial
> Attachments: feature_DefaultFileSelectorInfo_public.patch
>
>
> See $summary, and patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Commented: (VFS-148) Make DefaultFileSelectInfo public
Posted by "Adam Heath (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VFS-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495767 ]
Adam Heath commented on VFS-148:
--------------------------------
You missed the point. A walker implementation implemented elsewhere needs to make use of a FileSelectInfo implementation, to pass information to the FileSelector. With this class being package private, this other implementation has to make a full implementation of the FileSelectInfo interface.
I'm just trying to reduce code. If the class is made public, this other code can just instantiate an existing class, instead of having to use a separate implementation.
However, as I study the code more, what is the real purpose of FileSelectInfo? Why aren't the properties just passed directly into FileAcceptor? Wouldn't that make the code simpler to understand(less interfaces to deal with)?
> Make DefaultFileSelectInfo public
> ---------------------------------
>
> Key: VFS-148
> URL: https://issues.apache.org/jira/browse/VFS-148
> Project: Commons VFS
> Issue Type: New Feature
> Affects Versions: 1.1
> Reporter: Adam Heath
> Priority: Trivial
> Attachments: feature_DefaultFileSelectorInfo_public.patch
>
>
> See $summary, and patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org