You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "JeremyXin (via GitHub)" <gi...@apache.org> on 2026/07/27 11:48:57 UTC

[PR] [Feature][Connector-File-Base] Add optional PDF RAG metadata for file source [seatunnel]

JeremyXin opened a new pull request, #11571:
URL: https://github.com/apache/seatunnel/pull/11571

   <!--
   
   Thank you for contributing to SeaTunnel! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   ## Contribution Checklist
     - Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/seatunnel/issues).
     - Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
     - Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
   -->
   
   ### Purpose of this pull request
   
   <!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
   
   This PR adds optional RAG metadata support for PDF file source reading.
   
     Changes include:
   
     - add `pdf_rag_metadata_enabled` config for PDF sources
     - append stable RAG metadata columns in `PdfReadStrategy`: `source_uri`, `document_id`, `chunk_id`, `chunk_index`, `content_hash`
     - normalize file: URIs to keep metadata stable across equivalent local paths
     - make PDF empty-path schema inference consistent with Markdown/Binary behavior
     - add focused tests for PDF RAG metadata schema, stability, URI normalization, and empty-directory schema discovery
   
     This change is backward compatible: the new metadata columns are only appended when `pdf_rag_metadata_enabled`=true.
   
   
   ### Does this PR introduce _any_ user-facing change?
   
   <!--
   Note that it means *any* user-facing change including all aspects such as the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to the released SeaTunnel versions or within the unreleased branches such as dev.
   If no, write 'No'.
   If you are adding/modifying connector documents, please follow our new specifications: https://github.com/apache/seatunnel/issues/4544.
   -->
   
   
   ### How was this patch tested?
   
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   If you are adding E2E test cases, maybe refer to https://github.com/apache/seatunnel/blob/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-cdc-mysql-e2e/src/test/resources/mysqlcdc_to_mysql.conf, here is a good example.
   -->
   
   
   ### Check list
   
   * [ ] If any new Jar binary package adding in your PR, please add License Notice according
     [New License Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/developer/new-license.md)
   * [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
   * [ ] If necessary, please update `incompatible-changes.md` to describe the incompatibility caused by this PR.
   * [ ] If you are contributing the connector code, please check that the following files are updated:
     1. Update [plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties) and add new connector information in it
     2. Update the pom file of [seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
     3. Add ci label in [label-scope-conf](https://github.com/apache/seatunnel/blob/dev/.github/workflows/labeler/label-scope-conf.yml)
     4. Add e2e testcase in [seatunnel-e2e](https://github.com/apache/seatunnel/tree/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/)
     5. Update connector [plugin_config](https://github.com/apache/seatunnel/blob/dev/config/plugin_config)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Feature][Connector-File-Base] Add optional PDF RAG metadata for file source [seatunnel]

Posted by "JeremyXin (via GitHub)" <gi...@apache.org>.
JeremyXin commented on PR #11571:
URL: https://github.com/apache/seatunnel/pull/11571#issuecomment-5157263733

   @DanielLeens  Thanks for the careful review.
   
     I double-checked the current PR base and diff. The ImportClassCheckTest changes came from the latest `dev` sync, but they are not
     part of the current PR diff anymore.
   
     Current PR base:
     - `apache:dev` at `458cefdc5`
   
     Current PR head:
     - `933d1389b`
   
     I also rechecked the current `Files changed` set and `ImportClassCheckTest.java` is not included there. The effective diff only
     contains the PDF RAG metadata feature, related tests, and docs.
   
     So there is nothing additional to drop from the active PR diff on the current base. If you were looking at the merge history or
     an earlier compare view, that may explain the mismatch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Feature][Connector-File-Base] Add optional PDF RAG metadata for file source [seatunnel]

Posted by "DanielLeens (via GitHub)" <gi...@apache.org>.
DanielLeens commented on PR #11571:
URL: https://github.com/apache/seatunnel/pull/11571#issuecomment-5165360509

   Thanks for the additional current-head review.
   
   From Daniel's side, the previous documentation blocker is still closed for me, but the current unchanged head still needs a source update before another full Daniel re-review. In particular, I still want the unrelated `ImportClassCheckTest` refactor removed from this PR so the branch stays focused on the PDF RAG metadata change itself.
   
   Once that code update is pushed, I am happy to re-review the refreshed head from scratch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Feature][Connector-File-Base] Add optional PDF RAG metadata for file source [seatunnel]

Posted by "davidzollo (via GitHub)" <gi...@apache.org>.
davidzollo merged PR #11571:
URL: https://github.com/apache/seatunnel/pull/11571


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org