[GitHub] [flink] FangYongs commented on a diff in pull request #23455: [FLINK-25015][Table SQL/Client] change job name to sql when submitting queries using client

["FangYongs (via GitHub)" <gi...@apache.org>]

FangYongs commented on code in PR #23455:
URL: https://github.com/apache/flink/pull/23455#discussion_r1335701445


##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java:
##########
@@ -1050,10 +1052,15 @@ private TableResultInternal executeInternal(
     }
 
     private TableResultInternal executeQueryOperation(QueryOperation operation) {
+        String querySql = null;
+        if (operation instanceof QuerySqlOperation) {
+            querySql = ((QuerySqlOperation) operation).getQuerySql();
+        }
         CollectModifyOperation sinkOperation = new CollectModifyOperation(operation);
         List<Transformation<?>> transformations =
                 translate(Collections.singletonList(sinkOperation));
-        final String defaultJobName = "collect";
+        final String defaultJobName =

Review Comment:
   Job name will be used in the checkpoint path, is it ok when there're some special characters in the sql statement?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org