You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/04/01 13:12:21 UTC

[GitHub] [hudi] garyli1019 commented on a change in pull request #5202: [HUDI-3771] flink supports sync table information to aws glue

garyli1019 commented on a change in pull request #5202:
URL: https://github.com/apache/hudi/pull/5202#discussion_r840571581



##########
File path: hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/utils/HiveSyncContext.java
##########
@@ -48,7 +51,15 @@ private HiveSyncContext(HiveSyncConfig syncConfig, HiveConf hiveConf, FileSystem
   }
 
   public HiveSyncTool hiveSyncTool() {
-    return new HiveSyncTool(this.syncConfig, this.hiveConf, this.fs);
+    HiveSyncMode syncMode = HiveSyncMode.of(syncConfig.syncMode);
+    switch (syncMode) {
+      case HMS:

Review comment:
       the default sync mode in FlinkOptions is JDBC actually.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org