[GitHub] [lucene] iverase commented on pull request #809: LUCENE-10514: Component2D#Within methods should return NOTWITHIN when the query geometry contains the triangle

[GitBox <gi...@apache.org>]

iverase commented on PR #809:
URL: https://github.com/apache/lucene/pull/809#issuecomment-1103866748

   I run the performance test and no significant change on performance:
   
   ```
   Index time (sec)||Force merge time (sec)||Index size (GB)||Reader heap (MB)||
   ||Dev||Base||Diff ||Dev  ||Base  ||diff   ||Dev||Base||Diff||Dev||Base||Diff ||
   |456.0s|454.4s| 0%|0.0s|0.0s| 0%|2.24|2.24| 0%|0.00|0.00| 0%|
   ()
   ||Approach||Shape||M hits/sec      ||QPS            ||Hit count      ||
                    ||Dev||Base ||Diff||Dev||Base||Diff||Dev||Base||Diff||
   |point|intersects|0.00|0.00|-0%|353.65|354.71|-0%|2644|2644| 0%|
   |box|intersects|6.71|6.70| 0%|45.67|45.55| 0%|33081264|33081264| 0%|
   |distance|intersects|6.34|6.38|-1%|22.26|22.42|-1%|64062420|64062420| 0%|
   |poly 10|intersects|5.41|5.31| 2%|20.60|20.23| 2%|59064569|59064569| 0%|
   |polyMedium|intersects|0.48|0.48|-0%|30.14|30.14|-0%|528812|528812| 0%|
   |polyRussia|intersects|1.79|1.77| 1%|7.30|7.23| 1%|244848|244848| 0%|
   |point|contains|0.00|0.00|-0%|345.90|346.40|-0%|2644|2644| 0%|
   |box|contains|0.00|0.00|-1%|42.91|43.43|-1%|484|484| 0%|
   |distance|contains|0.00|0.00| 2%|23.44|23.08| 2%|384|384| 0%|
   |poly 10|contains|0.00|0.00| 0%|19.85|19.78| 0%|402|402| 0%|
   |polyMedium|contains|0.00|0.00|-2%|21.50|21.84|-2%|147|147| 0%|
   |point|within|0.00|0.00| 0%|396.12|394.72| 0%|0|0| 0%|
   |box|within|0.58|0.59|-1%|3.95|4.00|-1%|32911251|32911251| 0%|
   |distance|within|0.94|1.05|-10%|3.31|3.69|-10%|63868270|63868270| 0%|
   |poly 10|within|0.92|0.92| 0%|3.52|3.52| 0%|58873224|58873224| 0%|
   |polyMedium|within|0.06|0.06| 0%|3.79|3.78| 0%|522739|522739| 0%|
   |polyRussia|within|0.72|0.72|-1%|2.94|2.96|-1%|244661|244661| 0%|
   |point|disjoint|266.32|267.87|-1%|20.23|20.35|-1%|2962178156|2962178156| 0%|
   |box|disjoint|193.47|193.72|-0%|14.86|14.88|-0%|2929099536|2929099536| 0%|
   |distance|disjoint|144.27|144.37|-0%|11.20|11.21|-0%|2898118380|2898118380| 0%|
   |poly 10|disjoint|137.00|136.12| 1%|10.62|10.55| 1%|2903116231|2903116231| 0%|
   |polyMedium|disjoint|164.94|165.33|-0%|12.54|12.57|-0%|433924372|433924372| 0%|
   |polyRussia|disjoint|77.88|78.54|-1%|6.03|6.08|-1%|12920400|12920400| 0%|
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org