You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Scott Garland (JIRA)" <ji...@apache.org> on 2009/03/04 21:41:56 UTC
[jira] Created: (LUCENE-1552) IndexWriter.addIndexes(IndexReader[]
readers) doesn't correctly handle exception success flag.
IndexWriter.addIndexes(IndexReader[] readers) doesn't correctly handle exception success flag.
----------------------------------------------------------------------------------------------
Key: LUCENE-1552
URL: https://issues.apache.org/jira/browse/LUCENE-1552
Project: Lucene - Java
Issue Type: Bug
Affects Versions: 2.4
Environment: Java
Reporter: Scott Garland
After this bit of code in addIndexes(IndexReader[] readers)
try {
flush(true, false, true);
optimize(); // start with zero or 1 seg
success = true;
} finally {
// Take care to release the write lock if we hit an
// exception before starting the transaction
if (!success)
releaseWrite();
}
The success flag should be reset to "false" because it's used again in another try/catch/finally block.
TestIndexWriter.testAddIndexOnDiskFull() sometimes will hit this bug; but it's infrequent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-1552) IndexWriter.addIndexes(IndexReader[]
readers) doesn't correctly handle exception success flag.
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless resolved LUCENE-1552.
----------------------------------------
Resolution: Fixed
> IndexWriter.addIndexes(IndexReader[] readers) doesn't correctly handle exception success flag.
> ----------------------------------------------------------------------------------------------
>
> Key: LUCENE-1552
> URL: https://issues.apache.org/jira/browse/LUCENE-1552
> Project: Lucene - Java
> Issue Type: Bug
> Affects Versions: 2.4
> Environment: Java
> Reporter: Scott Garland
> Assignee: Michael McCandless
> Fix For: 2.4.1, 2.9
>
>
> After this bit of code in addIndexes(IndexReader[] readers)
> try {
> flush(true, false, true);
> optimize(); // start with zero or 1 seg
> success = true;
> } finally {
> // Take care to release the write lock if we hit an
> // exception before starting the transaction
> if (!success)
> releaseWrite();
> }
> The success flag should be reset to "false" because it's used again in another try/catch/finally block.
> TestIndexWriter.testAddIndexOnDiskFull() sometimes will hit this bug; but it's infrequent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1552) IndexWriter.addIndexes(IndexReader[]
readers) doesn't correctly handle exception success flag.
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless updated LUCENE-1552:
---------------------------------------
Fix Version/s: 2.9
2.4.1
Thanks! I'll fix on 2.4.1 as well, and re-spin the release candidate.
> IndexWriter.addIndexes(IndexReader[] readers) doesn't correctly handle exception success flag.
> ----------------------------------------------------------------------------------------------
>
> Key: LUCENE-1552
> URL: https://issues.apache.org/jira/browse/LUCENE-1552
> Project: Lucene - Java
> Issue Type: Bug
> Affects Versions: 2.4
> Environment: Java
> Reporter: Scott Garland
> Assignee: Michael McCandless
> Fix For: 2.4.1, 2.9
>
>
> After this bit of code in addIndexes(IndexReader[] readers)
> try {
> flush(true, false, true);
> optimize(); // start with zero or 1 seg
> success = true;
> } finally {
> // Take care to release the write lock if we hit an
> // exception before starting the transaction
> if (!success)
> releaseWrite();
> }
> The success flag should be reset to "false" because it's used again in another try/catch/finally block.
> TestIndexWriter.testAddIndexOnDiskFull() sometimes will hit this bug; but it's infrequent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Assigned: (LUCENE-1552) IndexWriter.addIndexes(IndexReader[]
readers) doesn't correctly handle exception success flag.
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless reassigned LUCENE-1552:
------------------------------------------
Assignee: Michael McCandless
> IndexWriter.addIndexes(IndexReader[] readers) doesn't correctly handle exception success flag.
> ----------------------------------------------------------------------------------------------
>
> Key: LUCENE-1552
> URL: https://issues.apache.org/jira/browse/LUCENE-1552
> Project: Lucene - Java
> Issue Type: Bug
> Affects Versions: 2.4
> Environment: Java
> Reporter: Scott Garland
> Assignee: Michael McCandless
>
> After this bit of code in addIndexes(IndexReader[] readers)
> try {
> flush(true, false, true);
> optimize(); // start with zero or 1 seg
> success = true;
> } finally {
> // Take care to release the write lock if we hit an
> // exception before starting the transaction
> if (!success)
> releaseWrite();
> }
> The success flag should be reset to "false" because it's used again in another try/catch/finally block.
> TestIndexWriter.testAddIndexOnDiskFull() sometimes will hit this bug; but it's infrequent.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org