You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "breautek (via GitHub)" <gi...@apache.org> on 2023/04/09 13:59:05 UTC
[GitHub] [cordova-android] breautek opened a new pull request, #1589: feat: InspectableWebview preference
breautek opened a new pull request, #1589:
URL: https://github.com/apache/cordova-android/pull/1589
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
Sister PR of https://github.com/apache/cordova-ios/pull/1300
Makes cordova-android honour the `InspectableWebview` preference in a similar fashion the iOS platform.
### Description
<!-- Describe your changes in detail -->
Like iOS, android will default to the original method of choosing if the inspecter should be enabled based on the module's debuggable flag. So if the preference is unset, the inspecter will be enabled on debug builds, and disabled on release builds.
If the preference is set and if, and only if the value is `"true"`, the webview inspecter will be forcefully enabled.
If the preference is set but is not `"true"` (including any invalid value), the webview inspector will be forcefully disabled.
Unlike iOS, Android has had the ability to independently control the inspecter programmatically for some time, so there is no Android OS limitation.
### Testing
<!-- Please describe in detail how you tested your changes. -->
Ran npm test
Manual obesrvations in HelloWorld test app.
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [x] I added automated test coverage as appropriate for this change
- [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [x] I've updated the documentation if necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-commenter commented on pull request #1589: feat: InspectableWebview preference
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1589:
URL: https://github.com/apache/cordova-android/pull/1589#issuecomment-1501136388
## [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1589?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1589](https://codecov.io/gh/apache/cordova-android/pull/1589?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (489ac98) into [master](https://codecov.io/gh/apache/cordova-android/commit/d4bfd5079b701671286e31dea2dedc885481491c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d4bfd50) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #1589 +/- ##
=======================================
Coverage 72.13% 72.13%
=======================================
Files 21 21
Lines 1751 1751
=======================================
Hits 1263 1263
Misses 488 488
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] breautek merged pull request #1589: feat: InspectableWebview preference
Posted by "breautek (via GitHub)" <gi...@apache.org>.
breautek merged PR #1589:
URL: https://github.com/apache/cordova-android/pull/1589
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org