You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/06/22 09:26:47 UTC

[GitHub] [incubator-apisix] scaat opened a new pull request #1754: doc: add oauth plugins Chinese docs.

scaat opened a new pull request #1754:
URL: https://github.com/apache/incubator-apisix/pull/1754


   NOTE: Please read the Contributing.md guidelines before submitting your patch:
   
   https://github.com/apache/incubator-apisix/blob/master/Contributing.md#how-to-add-a-new-feature-or-change-an-existing-one
   
   ### Summary
   
   SUMMARY_HERE
   
   ### Full changelog
   
   * [Implement ...]
   * [Add related tests]
   * ...
   
   ### Issues resolved
   
   Fix #1630
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] membphis commented on pull request #1754: doc: add oauth plugins Chinese docs.

Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #1754:
URL: https://github.com/apache/incubator-apisix/pull/1754#issuecomment-647452819


   add link to https://github.com/apache/incubator-apisix/edit/master/doc/zh-cn/README.md
   
   and we need to add English version link to https://github.com/apache/incubator-apisix/blob/master/doc/README.md 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] juzhiyuan commented on pull request #1754: doc: add oauth plugins Chinese docs.

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1754:
URL: https://github.com/apache/incubator-apisix/pull/1754#issuecomment-647422902


   LGTM about the doc fomat.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] membphis commented on pull request #1754: doc: add oauth plugins Chinese docs.

Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #1754:
URL: https://github.com/apache/incubator-apisix/pull/1754#issuecomment-647870491


   @scaat merged, many thx


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] membphis merged pull request #1754: doc: add oauth plugins Chinese docs.

Posted by GitBox <gi...@apache.org>.
membphis merged pull request #1754:
URL: https://github.com/apache/incubator-apisix/pull/1754


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] scaat commented on pull request #1754: doc: add oauth plugins Chinese docs.

Posted by GitBox <gi...@apache.org>.
scaat commented on pull request #1754:
URL: https://github.com/apache/incubator-apisix/pull/1754#issuecomment-647857875


   I have added a link to the document. @membphis 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-apisix] juzhiyuan edited a comment on pull request #1754: doc: add oauth plugins Chinese docs.

Posted by GitBox <gi...@apache.org>.
juzhiyuan edited a comment on pull request #1754:
URL: https://github.com/apache/incubator-apisix/pull/1754#issuecomment-647422902


   LGTM
   
   1. documentation format;
   2. Correct ASF header.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org