You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by sjcorbett <gi...@git.apache.org> on 2015/06/30 12:26:39 UTC
[GitHub] incubator-brooklyn pull request: BrooklynApi.getEntity handles ins...
GitHub user sjcorbett opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/728
BrooklynApi.getEntity handles instances of BuiltResponsePreservingError
`BuiltResponsePreservingError` can turn response entities into strings, breaking callers of `BrooklynApi.getEntity`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sjcorbett/incubator-brooklyn api-entity
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/728.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #728
----
commit 160f628f34cc2cacb0e3ad56fab5f9f9ccbf8494
Author: Sam Corbett <sa...@cloudsoftcorp.com>
Date: 2015-06-30T10:20:33Z
BrooklynApi.getEntity handles instances of BuiltResponsePreservingError
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: BrooklynApi.getEntity handles ins...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/728#issuecomment-118090545
Thanks @sjcorbett and @robertgmoss - merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: BrooklynApi.getEntity handles ins...
Posted by robertgmoss <gi...@git.apache.org>.
Github user robertgmoss commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/728#issuecomment-117123285
works fine for me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: BrooklynApi.getEntity handles ins...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/728
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: BrooklynApi.getEntity handles ins...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/728#issuecomment-118090723
How does this relate to https://github.com/apache/incubator-brooklyn/pull/730 (BROOKLYN-154)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: BrooklynApi.getEntity handles ins...
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/728#issuecomment-117118491
@robertgmoss Could you double check this works for you?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: BrooklynApi.getEntity handles ins...
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/728#issuecomment-118090956
It's separate.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---