You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "ByteYue (via GitHub)" <gi...@apache.org> on 2023/04/10 07:38:26 UTC
[GitHub] [doris] ByteYue opened a new pull request, #18510: [bug](be) fix accept null predicate mem leak
ByteYue opened a new pull request, #18510:
URL: https://github.com/apache/doris/pull/18510
# Proposed changes
Issue Number: close #xxx
The former logic inside accept null predicate would cause memory leak.
## Problem summary
Describe your changes.
## Checklist(Required)
* [ ] Does it affect the original behavior
* [ ] Has unit tests been added
* [ ] Has document been added or modified
* [ ] Does it need to update dependencies
* [ ] Is this PR support rollback (If NO, please explain WHY)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18510: [bug](be) fix accept null predicate mem leak
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18510:
URL: https://github.com/apache/doris/pull/18510#issuecomment-1501508875
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] gavinchou commented on a diff in pull request #18510: [bug](be) fix accept null predicate mem leak
Posted by "gavinchou (via GitHub)" <gi...@apache.org>.
gavinchou commented on code in PR #18510:
URL: https://github.com/apache/doris/pull/18510#discussion_r1161660849
##########
be/src/olap/accept_null_predicate.h:
##########
@@ -125,7 +126,8 @@ class AcceptNullPredicate : public ColumnPredicate {
bool* flags) const override {
if (column.has_null()) {
// copy original flags
- bool* original_flags = new bool[size];
+ auto original_flags_buf = std::make_unique<bool>(size);
Review Comment:
Ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18510: [bug](be) fix accept null predicate mem leak
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18510:
URL: https://github.com/apache/doris/pull/18510#issuecomment-1501736497
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] ByteYue commented on pull request #18510: [bug](be) fix accept null predicate mem leak
Posted by "ByteYue (via GitHub)" <gi...@apache.org>.
ByteYue commented on PR #18510:
URL: https://github.com/apache/doris/pull/18510#issuecomment-1501506072
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18510: [bug](be) fix accept null predicate mem leak
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18510:
URL: https://github.com/apache/doris/pull/18510#issuecomment-1501695720
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] ByteYue commented on pull request #18510: [bug](be) fix accept null predicate mem leak
Posted by "ByteYue (via GitHub)" <gi...@apache.org>.
ByteYue commented on PR #18510:
URL: https://github.com/apache/doris/pull/18510#issuecomment-1501734430
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] gavinchou commented on a diff in pull request #18510: [bug](be) fix accept null predicate mem leak
Posted by "gavinchou (via GitHub)" <gi...@apache.org>.
gavinchou commented on code in PR #18510:
URL: https://github.com/apache/doris/pull/18510#discussion_r1161660442
##########
be/src/olap/accept_null_predicate.h:
##########
@@ -60,7 +60,8 @@ class AcceptNullPredicate : public ColumnPredicate {
bool* flags) const override {
if (column.has_null()) {
// copy original flags
- bool* original_flags = new bool[size];
+ auto original_flags_buf = std::make_unique<bool>(size);
Review Comment:
Should it be `std::make_unique<bool[]>(size)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #18510: [bug](be) fix accept null predicate mem leak
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #18510:
URL: https://github.com/apache/doris/pull/18510
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18510: [bug](be) fix accept null predicate mem leak
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18510:
URL: https://github.com/apache/doris/pull/18510#issuecomment-1501695862
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org