[jira] [Commented] (ARROW-5081) [C++] Consistently use PATH_SUFFIXES in CMake config

["David Li (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARROW-5081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16806739#comment-16806739 ] 

David Li commented on ARROW-5081:
---------------------------------

Also c-ares uses both c-ares_ROOT and CARES_ROOT inconsistently.

I'll put up a patch for review once I wrangle our build and figure out what else is missing.

> [C++] Consistently use PATH_SUFFIXES in CMake config
> ----------------------------------------------------
>
>                 Key: ARROW-5081
>                 URL: https://issues.apache.org/jira/browse/ARROW-5081
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>            Reporter: David Li
>            Priority: Major
>
> In trying to set up a build using system libraries installed to non-default paths, CMake doesn't consistently search user-specified paths for libraries.
> For instance, FindDoubleConversion.cmake will look only at ${DoubleConversion_ROOT}/libdoubleconversion.so for the shared library, making it impossible to have a directory setup like doubleconversion/lib/*.so + doubleconversion/include. Other Find*.cmake files set PATH_SUFFIXES to also search the lib/ subdirectory; we should do this everywhere.
> Additionally, it seems the various Find*.cmake files set PATH_SUFFIXES inconsistently. Some hardcode their own list, others use CMAKE_LIBRARY_ARCHITECTURE.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)