You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by yi...@apache.org on 2020/10/06 20:35:55 UTC

[royale-asjs] 03/03: Add some methods so override doesn't result in compiler error.

This is an automated email from the ASF dual-hosted git repository.

yishayw pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git

commit 73dd273339f7a00ee75d8d9a1328e5ed5354d273
Author: Yishay Weiss <yi...@yell.com>
AuthorDate: Tue Oct 6 21:34:28 2020 +0100

    Add some methods so override doesn't result in compiler error.
---
 .../royale/spark/components/SkinnableContainer.as  |  8 ++---
 .../components/supportClasses/DropDownListBase.as  | 36 +++++++++++-----------
 .../supportClasses/SkinnableComponent.as           |  2 ++
 .../src/main/royale/spark/skins/SparkSkin.as       |  4 +++
 4 files changed, 28 insertions(+), 22 deletions(-)

diff --git a/frameworks/projects/SparkRoyale/src/main/royale/spark/components/SkinnableContainer.as b/frameworks/projects/SparkRoyale/src/main/royale/spark/components/SkinnableContainer.as
index 02da846..1c07a8b 100644
--- a/frameworks/projects/SparkRoyale/src/main/royale/spark/components/SkinnableContainer.as
+++ b/frameworks/projects/SparkRoyale/src/main/royale/spark/components/SkinnableContainer.as
@@ -1093,9 +1093,9 @@ public class SkinnableContainer extends SkinnableContainerBase implements IConta
      *  @playerversion AIR 1.5
      *  @productversion Royale 0.9.4
      */
-     /* override */ protected function partRemoved(partName:String, instance:Object):void
+     /* override protected function partRemoved(partName:String, instance:Object):void
     {
-         /* super.partRemoved(partName, instance);
+         super.partRemoved(partName, instance);
 
          if (instance == contentGroup)
         {
@@ -1132,8 +1132,8 @@ public class SkinnableContainer extends SkinnableContainerBase implements IConta
             
             contentGroup.mxmlContent = null;
             contentGroup.layout = null;
-        } */
-    }
+        } 
+    }*/
      
     //--------------------------------------------------------------------------
     //
diff --git a/frameworks/projects/SparkRoyale/src/main/royale/spark/components/supportClasses/DropDownListBase.as b/frameworks/projects/SparkRoyale/src/main/royale/spark/components/supportClasses/DropDownListBase.as
index 19e1b33..1d632cc 100644
--- a/frameworks/projects/SparkRoyale/src/main/royale/spark/components/supportClasses/DropDownListBase.as
+++ b/frameworks/projects/SparkRoyale/src/main/royale/spark/components/supportClasses/DropDownListBase.as
@@ -806,10 +806,10 @@ public class DropDownListBase extends List
      *  Called whenever we need to update the text passed to the labelDisplay skin part
      */
     // TODO (jszeto): Make this protected and make the name more generic (passing data to skin) 
-    /* mx_internal function updateLabelDisplay(displayItem:* = undefined):void
+    mx_internal function updateLabelDisplay(displayItem:* = undefined):void
     {
         // DropDownList and ComboBox will override this function
-    } */
+    }
     
     /**
      *  @private
@@ -1095,22 +1095,22 @@ public class DropDownListBase extends List
      *  @playerversion AIR 1.5
      *  @productversion Royale 0.9.4
      */
-    /* protected function dropDownController_closeHandler(event:DropDownEvent):void
-    {
-        addEventListener(FlexEvent.UPDATE_COMPLETE, close_updateCompleteHandler);
-        invalidateSkinState();
-        
-        if (!event.isDefaultPrevented())
-        {
-            // Even if the dropDown was programmatically closed, assume the selection 
-            // changed as a result of a previous user interaction
-            setSelectedIndex(userProposedSelectedIndex, true);  
-        }
-        else
-        {
-            changeHighlightedSelection(selectedIndex);
-        }
-    } */
+    //protected function dropDownController_closeHandler(event:DropDownEvent):void
+    //{
+        //addEventListener(FlexEvent.UPDATE_COMPLETE, close_updateCompleteHandler);
+        //invalidateSkinState();
+        //
+        //if (!event.isDefaultPrevented())
+        //{
+            //// Even if the dropDown was programmatically closed, assume the selection 
+            //// changed as a result of a previous user interaction
+            //setSelectedIndex(userProposedSelectedIndex, true);  
+        //}
+        //else
+        //{
+            //changeHighlightedSelection(selectedIndex);
+        //}
+    //}
 
     /**
      *  @private
diff --git a/frameworks/projects/SparkRoyale/src/main/royale/spark/components/supportClasses/SkinnableComponent.as b/frameworks/projects/SparkRoyale/src/main/royale/spark/components/supportClasses/SkinnableComponent.as
index 4ac1e10..130cbba 100644
--- a/frameworks/projects/SparkRoyale/src/main/royale/spark/components/supportClasses/SkinnableComponent.as
+++ b/frameworks/projects/SparkRoyale/src/main/royale/spark/components/supportClasses/SkinnableComponent.as
@@ -402,6 +402,8 @@ public class SkinnableComponent extends UIComponent
         */
     }
 
+    protected function partRemoved(partName:String, instance:Object):void {} // not implemented
+
 	//dataGroup copied from SkinnableDataContainer
 	/**
      *  An optional skin part that defines the DataGroup in the skin class 
diff --git a/frameworks/projects/SparkRoyale/src/main/royale/spark/skins/SparkSkin.as b/frameworks/projects/SparkRoyale/src/main/royale/spark/skins/SparkSkin.as
index 8e9208c..ce145ae 100644
--- a/frameworks/projects/SparkRoyale/src/main/royale/spark/skins/SparkSkin.as
+++ b/frameworks/projects/SparkRoyale/src/main/royale/spark/skins/SparkSkin.as
@@ -73,6 +73,10 @@ public class SparkSkin extends Skin
         super();
     }
     
+	public function get contentItems():Array {return []} // not implemented
+
+	public function get symbolItems():Array {return []} // not implemented
+
 	// not implemented
 	public function get colorizeExclusions() : Array { return []}
     /**