You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@weex.apache.org by sospartan <gi...@git.apache.org> on 2017/03/06 10:13:13 UTC
[GitHub] incubator-weex pull request #39: [android]fix list concurrent exception
GitHub user sospartan opened a pull request:
https://github.com/apache/incubator-weex/pull/39
[android]fix list concurrent exception
```
java.util.ConcurrentModificationException
at java.util.HashMap$HashIterator.nextEntry(HashMap.java:806)
at java.util.HashMap$EntryIterator.next(HashMap.java:843)
at java.util.HashMap$EntryIterator.next(HashMap.java:841)
at com.taobao.weex.ui.component.list.BasicListComponent.(BasicListComponent.java:618)
at com.taobao.weex.ui.view.listview.adapter.WXRecyclerViewOnScrollListener.(WXRecyclerViewOnScrollListener.java:270)
at android.support.v7.widget.RecyclerView.(RecyclerView.java:3954)
at android.support.v7.widget.RecyclerView.(RecyclerView.java:3115)
at android.support.v7.widget.RecyclerView.(RecyclerView.java:2917)
```
@YorkShen
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sospartan/incubator-weex 0.11-dev-fix-list-concurrent
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/39.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #39
----
commit b24469c1f3bcd1c45b132259c02e46433caf91e9
Author: acton393 <zh...@gmail.com>
Date: 2017-02-17T06:51:20Z
* [test] update
commit 9be458bfaece3b08406dd2c84e1c05fe5c6b427e
Author: sospartan <so...@gmail.com>
Date: 2017-02-17T07:08:35Z
* [test] fix ci script
commit e38930af209f91b5b85c42b1c880206d1b9e4945
Author: sospartan <so...@gmail.com>
Date: 2017-02-17T07:41:48Z
* [test] put js test to script
commit 212f463d4a0ecc6bd623cbe736da8735ec68510a
Author: sospartan <so...@gmail.com>
Date: 2017-02-17T07:43:41Z
Merge branch 'test-enable-ci-macaca-moveandroidci' into test-enable-ci-macaca
# Conflicts:
# test/run.sh
# test/scripts/components/scroll-event.test.js
commit 6b96827b0b73ca319d6796060ead976c85022ff5
Author: acton393 <zh...@gmail.com>
Date: 2017-02-17T08:10:00Z
* [ios] update script
commit 5b6b38315be7db857dd7be4b2b91ce9a9d3ad1f2
Author: sospartan <so...@gmail.com>
Date: 2017-02-17T08:26:42Z
* [test] update travis
commit 69e710f1b8998fa743ac7b54a1e987c02a4055a9
Author: sospartan <so...@gmail.com>
Date: 2017-02-17T08:27:26Z
Merge branch 'test-enable-ci-macaca' of github.com:alibaba/weex into test-enable-ci-macaca
commit 3eb74530e0db854b9e81850ff0d23290d835336f
Author: acton393 <ac...@users.noreply.github.com>
Date: 2017-02-17T08:30:23Z
Merge branch '0.11-dev' into test-enable-ci-macaca
commit 7091365b78e53e94386b7e9e6b34c80381dc6000
Author: acton393 <zh...@gmail.com>
Date: 2017-02-17T08:55:51Z
* [ios] update script
commit 69dd8d319820daaf7a0c3c2882b111f5565aac6b
Author: sospartan <so...@gmail.com>
Date: 2017-02-17T08:58:54Z
* [test] update travis
commit 46ca268ea537e4e338942ca918c901d5358c584d
Author: sospartan <so...@gmail.com>
Date: 2017-02-17T09:00:29Z
Merge branch 'test-enable-ci-macaca' of github.com:alibaba/weex into test-enable-ci-macaca
commit 876e2421dc8c96f17971e9bfbf476f43366f19f8
Author: sospartan <so...@gmail.com>
Date: 2017-02-17T09:10:16Z
* [test] revert circle ci
commit 325b269618f679e80b6349fc488780961e0f216a
Author: cxfeng <cx...@gmail.com>
Date: 2017-02-17T09:42:31Z
Merge commit '0b7d237cb8d7e4b5a0e9cfd4e2832cf76d0d51b1' into 0.11-dev
Conflicts:
ios/sdk/WeexSDK/Sources/Utility/WXConvert.m
package.json
commit e7cb972ed53fa7fdc5d9c3cec45a5792fee871a1
Author: sospartan <so...@gmail.com>
Date: 2017-02-17T09:43:38Z
* [test] update log
commit aa80716051e03f1c49ac67d87a255325fe7d974d
Author: zshshr <zh...@gmail.com>
Date: 2017-02-17T09:51:06Z
* [android] add recycle column-count attribute
commit 8559dfb6fa051773b251feb4cb16cae3a0004c64
Author: sospartan zheng <so...@apache.org>
Date: 2017-02-17T09:52:05Z
Merge branch '0.11-dev' into test-enable-ci-macaca
commit 298a6d8e32a7a57ce9edc9d3e31ef32e41fec679
Author: zshshr <zh...@gmail.com>
Date: 2017-02-17T09:52:11Z
Merge branch '0.11-dev' into 0.11-dev-suppport-recycle-attr
commit 95e442f92dcebec32866e861104682f3b7abb1a0
Author: sospartan <so...@gmail.com>
Date: 2017-02-17T10:32:59Z
* [test] update travis
commit c25c6256ac00893821461bc6a78076e7a11ff487
Author: sospartan zheng <so...@apache.org>
Date: 2017-02-17T10:36:01Z
Merge pull request #2480 from alibaba/test-enable-ci-macaca
enable macaca ci
commit 3fd0a7f57afb8be3fc8e819815e1022abb7f608f
Author: fkysly <fk...@gmail.com>
Date: 2017-02-17T14:33:44Z
+ [html5] fix scroll bug && add list header support
commit 66c15257380622961cacead1fe7f86543c22e10e
Author: MrRaindrop <te...@gmail.com>
Date: 2017-02-18T04:12:26Z
* [html5] add units.
commit e25db445ce2085fcfa765987b3680c4779ca0393
Author: MrRaindrop <te...@gmail.com>
Date: 2017-02-18T04:20:39Z
* [html5] fix slider and indicator
commit ceb43b1ebb2487460da11e0b739748e1a5500f22
Author: MrRaindrop <te...@gmail.com>
Date: 2017-02-18T04:28:47Z
* [html5] fix style udpates and indicator's default style.
commit c0d5730daf2624d2fa806e92b23f0ca12c0284c5
Author: MrRaindrop <te...@gmail.com>
Date: 2017-02-18T04:50:06Z
* [html5] fix lint
commit 213c69fac8279203c307f7bc115dfc154825d163
Author: MrRaindrop <te...@gmail.com>
Date: 2017-02-18T06:35:16Z
* [html5] fix text lines and example's line-height units.
commit e61c8bf70489cc647ea50d56654f9ad0f1453d9d
Author: \u9690\u98ce <cx...@gmail.com>
Date: 2017-02-20T02:43:22Z
Merge remote-tracking branch 'upstream/0.11-dev' into ios-feature-grid
commit 16e43ce8b23dca399d64b0314be6e1e67801b1d6
Author: \u9690\u98ce <cx...@gmail.com>
Date: 2017-02-20T02:45:43Z
* [ios] fix typo
commit 48f0e9e520a311d63ff9202b35c5b0bb2325be1f
Author: \u9690\u98ce <cx...@gmail.com>
Date: 2017-02-20T02:46:27Z
* [test] update gemfile.lock
commit 7d9aec26f9d72a344dabc8efc6b50e9923c49ba2
Author: \u9690\u98ce <cx...@gmail.com>
Date: 2017-02-20T02:52:47Z
* [ios] fix compile warning
commit e5025346ec991b00832fcafc146b17c2c06d0893
Author: \u9f50\u5c71 <su...@163.com>
Date: 2017-02-20T03:12:25Z
* [ios] bug fix: optimize parameter match function
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #39: [android]fix list concurrent exception
Posted by sospartan <gi...@git.apache.org>.
Github user sospartan closed the pull request at:
https://github.com/apache/incubator-weex/pull/39
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #39: [android]fix list concurrent exception
Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/39
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true" data-kind="Error">
4 Errors
</th>
</tr>
</thead>
<tbody>
<tr>
<td>:no_entry_sign:</td>
<td data-sticky="false">Objective-C file \u2018ios/sdk/WeexSDK/dependency/SRWebSocket.m\u2019 does not have the copyright header.</td>
</tr>
<tr>
<td>:no_entry_sign:</td>
<td data-sticky="false">Objective-C file \u2018ios/sdk/WeexSDKTests/WXFloatCompareTests.m\u2019 does not have the copyright header.</td>
</tr>
<tr>
<td>:no_entry_sign:</td>
<td data-sticky="false">Objective-C file \u2018ios/sdk/WeexSDKTests/WXRootViewTests.m\u2019 does not have the copyright header.</td>
</tr>
<tr>
<td>:no_entry_sign:</td>
<td data-sticky="false">Objective-C file \u2018ios/sdk/WeexSDKTests/WXStorageTests.m\u2019 does not have the copyright header.</td>
</tr>
</tbody>
</table>
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true" data-kind="Warning">
4 Warnings
</th>
</tr>
</thead>
<tbody>
<tr>
<td>:warning:</td>
<td data-sticky="false">Big PR</td>
</tr>
<tr>
<td>:warning:</td>
<td data-sticky="false"><strong><a href="https://github.com/sospartan/incubator-weex/blob/4418c330c1181bb6d0a8de9f9ee8b07e2a335646/ios/sdk/WeexSDKTests/WXStorageTests.m#L123">ios/sdk/WeexSDKTests/WXStorageTests.m#L123</a></strong>: unused variable \u2018tsNow\u2019 [-Wunused-variable] <br /><code>
NSTimeInterval tsNow = [[NSDate date] timeIntervalSince1970];
</code></td>
</tr>
<tr>
<td>:warning:</td>
<td data-sticky="false"><strong><a href="https://github.com/sospartan/incubator-weex/blob/4418c330c1181bb6d0a8de9f9ee8b07e2a335646/ios/sdk/WeexSDKTests/WXStorageTests.m#L227">ios/sdk/WeexSDKTests/WXStorageTests.m#L227</a></strong>: unused variable \u2018tsNow\u2019 [-Wunused-variable] <br /><code>
NSTimeInterval tsNow = [[NSDate date] timeIntervalSince1970];
</code></td>
</tr>
<tr>
<td>:warning:</td>
<td data-sticky="false"><strong><a href="https://github.com/sospartan/incubator-weex/blob/4418c330c1181bb6d0a8de9f9ee8b07e2a335646/ios/sdk/WeexSDKTests/WXStorageTests.m#L228">ios/sdk/WeexSDKTests/WXStorageTests.m#L228</a></strong>: unused variable \u2018ts\u2019 [-Wunused-variable] <br /><code>
NSTimeInterval ts = [infoDic[@"key4"][@"ts"] doubleValue];
</code></td>
</tr>
</tbody>
</table>
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true" data-kind="Message">
1 Message
</th>
</tr>
</thead>
<tbody>
<tr>
<td>:book:</td>
<td data-sticky="false">Executed 53 tests, with 0 failures (0 unexpected) in 88.377 (88.684) seconds</td>
</tr>
</tbody>
</table>
<p align="right" data-meta="generated_by_danger">
Generated by :no_entry_sign: <a href="http://danger.systems/">danger</a>
</p>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---